unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timotej Lazar <timotej.lazar@araneo.si>
To: Bruno Victal <mirai@makinata.eu>
Cc: 66103@debbugs.gnu.org
Subject: [bug#66103] [PATCH] gnu: keepassxc: Update to 2.7.6.
Date: Thu, 21 Sep 2023 08:41:48 +0200	[thread overview]
Message-ID: <87sf789ger.fsf@araneo.si> (raw)
In-Reply-To: <87o7hwzrfx.fsf@makinata.eu>

Bruno Victal <mirai@makinata.eu> [2023-09-20 18:26:42+0100]:
> Timotej Lazar <timotej.lazar@araneo.si> writes:
>> @@ -178,10 +174,7 @@ (define-public keepassxc
>>                  ;; Fails with "TestCli::testClip() Compared values are not the
>>                  ;; same".  That test also requires a phase with (setenv
>>                  ;; "QT_QPA_PLATFORM" "offscreen") in order to work.
>> -                (invoke "ctest" "--exclude-regex" "testcli"))))
>> -          (add-after 'install 'wrap-qt
>> -            (lambda* (#:key inputs #:allow-other-keys)
>> -              (wrap-qt-program "keepassxc" #:output #$output #:inputs inputs))))))
>> +                (invoke "ctest" "--exclude-regex" "testcli")))))))
>
> Can you confirm if this is still necessary?
> I see that upstream has this commit [1] that suggests the issue has
> already been fixed?

The test still fails. I tried setting QT_QPA_PLATFORM as mentioned in
the comment to no effect. The test also fails in a different way without
a writable HOME, but after setting it I got the message in the comment.

Thanks for the review!




  reply	other threads:[~2023-09-21  6:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 14:40 [bug#66103] [PATCH] gnu: keepassxc: Update to 2.7.6 Timotej Lazar
2023-09-20 17:26 ` Bruno Victal
2023-09-21  6:41   ` Timotej Lazar [this message]
2023-09-23 13:14 ` [bug#66103] [PATCH v2] gnu: keepassxc: Switch to qt-build-system Timotej Lazar
2023-09-28 16:36   ` bug#66103: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf789ger.fsf@araneo.si \
    --to=timotej.lazar@araneo.si \
    --cc=66103@debbugs.gnu.org \
    --cc=mirai@makinata.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).