unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Munyoki Kilyungi <me@bonfacemunyoki.com>
To: jgart <jgart@dismail.de>, Hilton Chain <hako@ultrarare.space>,
	65194@debbugs.gnu.org
Cc: fanquake <fanquake@gmail.com>, Lars-Dominik Braun <lars@6xq.net>,
	Marius Bakke <marius@gnu.org>
Subject: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Mon, 02 Oct 2023 11:14:54 +0300	[thread overview]
Message-ID: <87sf6t4f0h.fsf@saitama.mail-host-address-is-not-set> (raw)
In-Reply-To: <0e8d212864503b6022ee496079a78eb2@dismail.de>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

"jgart" <jgart@dismail.de> aliandika:

> Hi Guixers,
>
> Thanks for the patches.
>
> Can you also patch these methods to use our binarie executables in Guix?
>
> https://github.com/ronaldoussoren/altgraph/blob/master/altgraph_tests/test_dot.py#L52
>
I've done a build of python-alt-graph and it
builds just file, tests and all so ...
> Lars or someone else,
>
> Feel free to let me know if not needed. I'm unsure of when we should and shouldn't for Python libraries sometimes.
>

I doubt we need to patch the tests ase you had
earlier indicated since the tests still pass---I
don't know why though.
Just my 2¢s.

> Should we document our policy for that in the manual?
>
> all best,
>
> jgart

-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2023-10-02  8:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  8:41 [bug#65194] [PATCH] gnu: add python-altgraph Michael Ford
2023-09-29  7:30 ` [bug#65194] [PATCH v2] gnu: Add python-altgraph Hilton Chain via Guix-patches via
2023-09-29 11:33 ` [bug#65194] [PATCH v3] " Hilton Chain via Guix-patches via
2023-09-30  2:09 ` jgart via Guix-patches via
2023-10-02  8:14   ` Munyoki Kilyungi [this message]
2023-10-02 13:59   ` jgart via Guix-patches via
2023-10-03 13:32   ` jgart via Guix-patches via
2023-10-03 14:26     ` Michael Ford
2023-10-03 16:49     ` jgart via Guix-patches via
2023-10-04  1:51     ` bug#65194: " jgart via Guix-patches via
2023-10-04 10:04       ` [bug#65194] " Munyoki Kilyungi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf6t4f0h.fsf@saitama.mail-host-address-is-not-set \
    --to=me@bonfacemunyoki.com \
    --cc=65194@debbugs.gnu.org \
    --cc=fanquake@gmail.com \
    --cc=hako@ultrarare.space \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).