From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6PNJAqvOKmXDfgEAauVa8A:P1 (envelope-from ) for ; Sat, 14 Oct 2023 19:23:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6PNJAqvOKmXDfgEAauVa8A (envelope-from ) for ; Sat, 14 Oct 2023 19:23:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87DC8633F1 for ; Sat, 14 Oct 2023 19:23:54 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=I4K842hs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697304234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZJt9kRNx97pWzUrxGmSPjiD29tWBZV/Zf8r5gzKymyo=; b=tV5sjZc1H/kJQspVFeWQwXAoYtJfCQ3g/TT0NV+aGMo/YPAT7g5DUCeB3/z8qMkEw7Hy1J enl1Ply52CehqeW3EY/PzUM6lB75yQpmdbW6YvU79MjFh+tcPTHLxqmIqVmMMIyXP0bwTd LAxTRq31fta2hJ/WzgQh96u3WQ088yknT96NrJaNvrtZ5TIacbOAXkcyXxemTJNu8oPRRa LdOHsw5nMZJlfKBTCJl6uYwHgEkhZJW7OVkM+dlwQH+Xzc/7kkmvZJ2WeTOaWu1EruDEgd oLOXOsN+/ao2KQGn1J2aUQjRI1FjRYbtNMj/qdu2oNW9oTqsay+6ILnckSAB6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697304234; a=rsa-sha256; cv=none; b=Y9al8wjXJyCxiVmEqUdgxsGFwJUyFU1fRhRt327o+kDK/XqG0hPUodVKfLo1ZKXxiI61BL ZM41c9MBtMQ1/qb/ZFC2hIcm2kMN1A2NgwWYHNUheaRIF2ZLgXxnhp9XhreHkpqOZK654u gj/2z8M8bY6RXguydPf7TbYgXQYCnydCiWGZ9EkqbGMjS2hTVkYJFyWe0bMAa1bibWq3FO k7XEieoyfgYjHKdqVOl71LIW0sFrozhYbw8oB5Q8QDjdXxP9ur1TWbRv2vZXIabZ3NNMwj JZMIKBelxGP+Me91Seo5SVHRNEJBVgCwwG/xRL4CP7cCCR2+OHW7xbdB8qjVLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=I4K842hs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qriMW-0001VT-Au; Sat, 14 Oct 2023 13:23:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qriMU-0001V6-QZ for guix-patches@gnu.org; Sat, 14 Oct 2023 13:23:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qriMU-0008Ey-Io for guix-patches@gnu.org; Sat, 14 Oct 2023 13:23:38 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qriMs-00039q-83 for guix-patches@gnu.org; Sat, 14 Oct 2023 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66491] [maintenance] hydra: build-package-metadata: Add boolean for Git submodules in sources.json. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2023 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66491 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Simon Tournier Cc: 66491@debbugs.gnu.org Received: via spool by 66491-submit@debbugs.gnu.org id=B66491.169730422612109 (code B ref 66491); Sat, 14 Oct 2023 17:24:02 +0000 Received: (at 66491) by debbugs.gnu.org; 14 Oct 2023 17:23:46 +0000 Received: from localhost ([127.0.0.1]:50377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qriMc-00039F-Dk for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qriMa-000392-A6 for 66491@debbugs.gnu.org; Sat, 14 Oct 2023 13:23:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qriM7-0008Bf-5v; Sat, 14 Oct 2023 13:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ZJt9kRNx97pWzUrxGmSPjiD29tWBZV/Zf8r5gzKymyo=; b=I4K842hsECe9ltplVPIs cbXMlWVIHBKn91X10ON/HW+aNLi58Md9vzjgRHlsgLerprjiGT6CIctAEPMD2DxpGcYXQ1GCB00v5 RCwZ3PCrZE3yVqSxm5CLXK6cBYMPB5qdeJgxF5MrNgC+FkJ3zUTykuTtnls/IYN7ws3pBjIpoViWG Yu20bY3E/2kmOipns2FxqEdvc4ueiB8FPL9nkMwEd0bU7l2e46FUWr+Q7J4YSigE2a2mFonRkjrR6 ecAUg26xvettn2IMpfvQ0ro2wNh/StFVI8j9B02yFQuQIZM+sy6r4SqCbeAkFZMK7/f/zQYZonZ0k p+v3thNL5hxECg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20231012123931.390137-1-zimon.toutoune@gmail.com> (Simon Tournier's message of "Thu, 12 Oct 2023 14:39:31 +0200") References: <20231012123931.390137-1-zimon.toutoune@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Navet X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 14 Oct 2023 19:23:13 +0200 Message-ID: <87sf6dce4e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.88 X-Migadu-Queue-Id: 87DC8633F1 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.88 X-TUID: AGLH1Wz9mMTn Hi, Simon Tournier skribis: > This format had been discussed in > > > * hydra/build-package-metadata.scm (origin->json)[resolve]: Add the keywo= rd > 'submodule' when the Git reference is recursive. [...] > ,@(if (eq? method git-fetch) > - `(("git_ref" . ,(git-reference-commit uri))) > + `(("git_ref" . ,(git-reference-commit uri)) > + ,@(if (git-reference-recursive? uri) > + '(("submodule" . "true")) > + '())) I think you=E2=80=99ll want to make it #t instead of "true", so that it translates to the Boolean true, not the string "true": --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (scm->json-string '((a . "true"))) $8 =3D "{\"a\":\"true\"}" scheme@(guile-user)> (scm->json-string '((a . #true))) $9 =3D "{\"a\":true}" --8<---------------cut here---------------end--------------->8--- Otherwise LGTM! Thanks, Ludo=E2=80=99.