From: Mathieu Othacehe <othacehe@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 68202@debbugs.gnu.org
Subject: [bug#68202] [PATCH 5/5] gnu: libsigsegv: Fix building for x86_64-linux-gnux32.
Date: Wed, 03 Jan 2024 09:43:32 +0100 [thread overview]
Message-ID: <87sf3ezu17.fsf@gnu.org> (raw)
In-Reply-To: <8e2a3ae4b8c3088d7c6d857e88b3dd394afb57c6.1704179455.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 2 Jan 2024 09:27:36 +0200")
Hello Efraim,
> + ;; On some architectures 'struct sigcontext' gets redefined from
> + ;; %linux-libre-headers/include/asm/sigcontext.h
> + ,@(cond ((target-mips64el?)
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'patch-mips-old-h
> + (lambda _
> + (substitute* "src/fault-linux-mips-old.h"
> + (("#include <asm/sigcontext\\.h>") "")))))))
> + ((target-x32?)
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'patch-linux-x86_64-old-h
> + (lambda _
> + (substitute* "src/fault-linux-x86_64-old.h"
> + (("#include <asm/sigcontext\\.h>") "")))))))
> + (else '()))))
> (description
> "GNU libsigsegv is a library to handle page faults, which occur when a
> program tries to access an unavailable region of memory, in user mode. By
#67859 is doing more or less the same thing, but for x86_64 as a
whole. Could you maybe replace `target-x32` by `target-x86`?
Maybe we should come up with a list of architectures that need that kind
of fix in libsigsegv and patch all the src/fault-linux-xxx-old-h?
The rest of the series seems fine to me.
Thanks,
Mathieu
next prev parent reply other threads:[~2024-01-03 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 7:26 [bug#68202] [PATCH 0/5] Add support for x86_64-linux-gnux32 Efraim Flashner
2024-01-02 7:27 ` [bug#68202] [PATCH 1/5] gnu: " Efraim Flashner
2024-01-02 7:27 ` [bug#68202] [PATCH 2/5] gnu: Add target-x32? Efraim Flashner
2024-01-08 9:20 ` Simon Tournier
2024-01-08 10:05 ` Efraim Flashner
2024-01-02 7:27 ` [bug#68202] [PATCH 3/5] gnu: openssl: Fix building on x86_64-linux-gnux32 Efraim Flashner
2024-01-02 7:27 ` [bug#68202] [PATCH 4/5] gnu: gmp: " Efraim Flashner
2024-01-02 7:27 ` [bug#68202] [PATCH 5/5] gnu: libsigsegv: Fix building for x86_64-linux-gnux32 Efraim Flashner
2024-01-03 8:43 ` Mathieu Othacehe [this message]
2024-01-03 8:53 ` Efraim Flashner
2024-01-05 11:22 ` bug#68202: [PATCH 0/5] Add support " Efraim Flashner
2024-01-08 17:14 ` [bug#68202] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf3ezu17.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=68202@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).