From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id YC6+KxiNsWUqPQAA62LTzQ:P1 (envelope-from ) for ; Wed, 24 Jan 2024 23:20:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YC6+KxiNsWUqPQAA62LTzQ (envelope-from ) for ; Wed, 24 Jan 2024 23:20:08 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TXwjRepl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706134808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gDOSguglnGspRRn6mf4FKkaFBLkAiUZZN2wzYBPwi3I=; b=Hox05aO+xGbHDofsE1sM3LSZlubUC42e029n7nxkiZTURSwm7JOPo4H1fUa9R/zrHTFTjT g3ZEia8gCnmOnuNAKrA9o45DwPNzx2EKwQPb4hotkvwbT8cBQtScfvUBgYq+TsoDHWJd/8 R23jXCYMZRbPrbV0R8VNvhxQeKtwEavI961FNXA0slapaq296J9pquRTdCZCKlKze2mVAz raL2pa72jml053LZnH/ZHYah7KdeMaQn2KlkjuiERHM5brK827LzK++86Ve4Q8fmRhRciT YhA0fhq20ezTlR9zfwGjPDdz8FvMkKaj4J6Y3HJ1/wR6kBTi+N25L8k0MlLoEQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TXwjRepl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706134808; a=rsa-sha256; cv=none; b=WVJEHYMOB47rZXfGeTyLQdFX0KznW5RusydSJgkNt9/VKgmMhWN4/qUoBmX1uTHPFV8AbO Gp4bROviU5NS8MJhKPBdAinrjLuxyQ/66OX7J0apFZM6+iKSeDT0hNdSKW9MKvcd3JdD7p m3dZSI2arVwSm72/MmjAXIvK8IHklMO+Xtz2pAa2zAL/UXH01b0kTnyMQzQLNL6y7rz88c //JXtLOvNOi4dWKSTft9YvjPGO3CYktwR/lYVZSYn9Vg0CYgY9InThDzQsKcbtCpT/TneC K5sQwRlI9WpzCoEGZSzzlwNEQ6BoJYH0VbSIHU9x1dH9qJ1h5Os8xWkiVGO54A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 606B855ED7 for ; Wed, 24 Jan 2024 23:20:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSlbF-0007P4-VH; Wed, 24 Jan 2024 17:20:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSlbB-0007O1-5u for guix-patches@gnu.org; Wed, 24 Jan 2024 17:19:57 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSlbA-0000QT-H9 for guix-patches@gnu.org; Wed, 24 Jan 2024 17:19:56 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSlbF-0000LE-W1 for guix-patches@gnu.org; Wed, 24 Jan 2024 17:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68641] [PATCH 17/19] gnu: libpasastro: Use G-Expressions. References: In-Reply-To: Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jan 2024 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68641 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 68641@debbugs.gnu.org Received: via spool by 68641-submit@debbugs.gnu.org id=B68641.17061347791274 (code B ref 68641); Wed, 24 Jan 2024 22:20:01 +0000 Received: (at 68641) by debbugs.gnu.org; 24 Jan 2024 22:19:39 +0000 Received: from localhost ([127.0.0.1]:46812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlas-0000KU-NQ for submit@debbugs.gnu.org; Wed, 24 Jan 2024 17:19:39 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:56408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlaq-0000KE-8I for 68641@debbugs.gnu.org; Wed, 24 Jan 2024 17:19:37 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40eac352733so41920605e9.0 for <68641@debbugs.gnu.org>; Wed, 24 Jan 2024 14:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706134765; x=1706739565; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=gDOSguglnGspRRn6mf4FKkaFBLkAiUZZN2wzYBPwi3I=; b=TXwjReplX/7tWHfijjAr+CCKBS3Ti9ng/YqEAMgaq9aT+xXCr6yls6RXadFXIY2Ako pHoNZitic4DNQPRKWksWPl2voJzmrN3c1XsN81hdbXhMRCaeMSUwGZdy3gi1UL0zkomS 9sugOZzPk6vry+WkCIBRtIGnVXCUt3a4amG7A8p31qzLjlubV7uFm1FPsEUrUjpgPyj8 7DokeubTmv7eUurJlG+BH7GL2oX0GRBZQT2WyVHDbSei6ZsQuLAp0JAG7LqKVmCczaLa dgfGU8xMdiRxMSHTle89lZJ7O4gBy3WHyUhBD2xlR8MdZkdZqHVj6jdZ+MwRwgXWtD2Z v9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706134765; x=1706739565; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gDOSguglnGspRRn6mf4FKkaFBLkAiUZZN2wzYBPwi3I=; b=Dr3OWcMUKRxkWSWcQCkjlAaQhf5GYTg+ASF6D/B2jA7loyDgkNUChzK1lF1k8MmCL8 s1iHdMXBXeAPHG39yUdQbEklG+BGqRg5zk3bSKJ3XsnCJOmlcwMY1V/SxQutrzGEy9rb oUph1nP1FwQizMenZYPRdk4cj3x1oEjX7vtIg8+cDiLsSh9sPgclnw5jgc404vFa2h3P r3cyML1oU9nCBZJxV0fpKPL32YqYfOxyzY+atReLurAM6vFZfVSINUjCxYA4y+LEIxBM fqXYzQWJ6WsQvIl5Wgy/exDvSgsQci3gLmkZauIVpa0ah7gmX8wDBCXcE6+KSryYQ58X N6cg== X-Gm-Message-State: AOJu0YxDADLjLVyYVPKDRqw1Jf2g7oPhrmw0B6+14dVgxtv78uHG2LVN FF11nNzMiHFN2r46XDDxk5/3g8x/u0gOi7Na/OBSXGttr1DASrSzI6Sc2lTDPyg= X-Google-Smtp-Source: AGHT+IEStrKINr/Wm8Ix+m5UdzYVadIMamdE2GkJEsnQ9jvuztyInBFQwRDCO1PnSaYCzx2uxTro2w== X-Received: by 2002:a05:600c:880f:b0:40d:6f01:c39d with SMTP id gy15-20020a05600c880f00b0040d6f01c39dmr1359848wmb.186.1706134764409; Wed, 24 Jan 2024 14:19:24 -0800 (PST) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040ecd453e8esm402185wms.34.2024.01.24.14.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:19:23 -0800 (PST) From: Sharlatan Hellseher Date: Wed, 24 Jan 2024 22:19:21 +0000 Message-ID: <87sf2ml6hi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -12.09 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -12.09 X-Migadu-Queue-Id: 606B855ED7 X-TUID: ht0JEj0MO+i0 --=-=-= Content-Type: text/plain Hi Efraim, Thank you for the review and feedback! > This package compiles just fine for riscv64 so there's no reason to > limit it to only certain architectures. That's is a great new, I did not try to build it on any other OS or platform. The reason I've add that flags is not a standard Makfile coming with the project. https://github.com/pchev/libpasastro/blob/master/Makefile --8<---------------cut here---------------start------------->8--- all: ifeq ($(OS_TARGET),win32) $(MAKE) -C getdss -f Makefile.win32 all $(MAKE) -C plan404 -f Makefile.win32 all $(MAKE) -C wcs -f Makefile.win32 all else ifeq ($(OS_TARGET),win64) $(MAKE) -C getdss -f Makefile.win64 all $(MAKE) -C plan404 -f Makefile.win64 all $(MAKE) -C wcs -f Makefile.win64 all else ifeq ($(CPU_TARGET),i386) $(MAKE) -C getdss all arch_flags=-m32 $(MAKE) -C plan404 all arch_flags=-m32 $(MAKE) -C wcs all arch_flags=-m32 else ifeq ($(CPU_TARGET),x86_64) $(MAKE) -C getdss all arch_flags=-m64 $(MAKE) -C plan404 all arch_flags=-m64 $(MAKE) -C wcs all arch_flags=-m64 else $(MAKE) -C getdss all $(MAKE) -C plan404 all $(MAKE) -C wcs all endif endif endif endif clean: ifeq ($(OS_TARGET),win32) $(MAKE) -C getdss -f Makefile.win32 clean $(MAKE) -C plan404 -f Makefile.win32 clean $(MAKE) -C wcs -f Makefile.win32 clean else ifeq ($(OS_TARGET),win64) $(MAKE) -C getdss -f Makefile.win64 clean $(MAKE) -C plan404 -f Makefile.win64 clean $(MAKE) -C wcs -f Makefile.win64 clean else $(MAKE) -C getdss clean $(MAKE) -C plan404 clean $(MAKE) -C wcs clean endif endif ifeq ($(OS_TARGET),darwin) install: ./install_darwin.sh $(PREFIX) else install: ./install.sh $(PREFIX) $(CPU_TARGET) install_win: ./install_win.sh win32 $(PREFIX) install_win64: ./install_win.sh win64 $(PREFIX) endif --8<---------------cut here---------------end--------------->8--- > (%current-target-system) returns i686-linux-gnu for the first one, so > it'd probably be better to use cond and (target-x86-32?) for the first > one. > > I'm not actually convinced you need any of the flags for OS_TARGET or > CPU_TARGET (except perhaps for cross-compiling), does it make a > difference between compiled with or without? I would dedicate some time to figure out how to satisfy custom Makefile to be compatible for larger range of systems available in Guix. Putting to my TODO for 2024/02 updates. Regards, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmWxjOkACgkQdtcnv/Ys 0rUqmg//anhRSUOi6XfQqAcHoa8qHaRalDPqQHM+3al852OUrtpGwKw++tIZ3vVY wzW4pNLmZBrzK/w8mvINhjQmPmMdueFCKBl1OAHJXIjI24Z10BXI4Oehz4l/Ntun k9EqAsK+aFYBL/9rutNYef+yGFJwIWHjGoqhU6iEs1kUYeqIVZhrYVGSWH1cAyQ1 piI8LOS4HyxXsc34FJ3YjpXsyS5DZmc9WRbx3hWAYUHxWr+leswB9/bYMcY5eGJU l3BKEUuP0LjWGvmCEJR5HTimsQbJOvL6eKnmLjLYM4ikD7EM5ambWUawsvcKuEUT lAHWiRVj4/eUduzMWE6ams8bwPahcnXQRLZjCI/o5TqTL9RYBqdHXsp5r/HFYl7O 8+ChG08AaQEroCBpDTu46QNBhDonYWtnPxqkNHblqjeN3w4uWrt8nzCGIRLkzmx9 GHEUMwJxBf0s4CkE4jDnd/btIvbEXKsyL2wnUmaQJTh8w8Rm4eRADSLwGn6ecZN5 5Cgf7+yUuHJpqOFXewUWb9OIDbUiGWjYcgBDC2LHFDjLrk/ncIcFIFlfMjgjOYc0 2lnHdFd9V+D373Bki4Gt1Yh4lvIaAZsNuUSgnWk5DdqoQZDdOhancFN/KO3emVlJ Rxj5SdKNSsOSnl/uoNyV20NBWTle/VYoPxYnt8Nib21V1G5oWYA= =v/IJ -----END PGP SIGNATURE----- --=-=-=--