From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id cOqENH4pFmaq1QAAe85BDQ:P1 (envelope-from ) for ; Wed, 10 Apr 2024 07:54:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id cOqENH4pFmaq1QAAe85BDQ (envelope-from ) for ; Wed, 10 Apr 2024 07:54:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712728446; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=C3f22oQ3NMMDsFQHt4eX8czSLn1Kv5kDwmET9DYB6xk=; b=Nhpyt5oVhX30NgV9OtYn8TfFUHtM5reXc71mJedZ74ST3eTu+boCNjk6cF7lwjHum9w5Fu bOFljrbXc5zJ4iLm8cS8xejEcBBR3+jPuipnP23PkIwkD7nhdh5rqc2tKK+4AIFJFTqeex pFXa3q2fFTg0g050wX+zP9BmjphbAE8zTsLChrpSYOFeuUuDd722h+RkF9nGoE/t1tqQmd j9TyRoR27An9b/Wig9uPoRYsZddGS/OR5yRJV5Gb3Xnr4gyouXDrVhK8IM9eOuYIg9Olam 7z22ZAd0Yx6LM3RHZwUagZtt41rWokBbzIiXqPfm/x1m7eg1aCQa7hTKjBLGmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712728446; a=rsa-sha256; cv=none; b=TlaKpVyw6nJvvklCGMoQEObJ3bybvdh0a+8ABmp4hRqDNKmxJbgTSEAFR1Kj6OHkHZmFhQ LvPg+wt6GJFR+q5us3ol4wRyh32wry1juETSluvsYkjroaN6rShjHI+I8qF3hepohXHxqa qxIaP4rclSCjJEFi8Af71a0YRRBqeqzqC2IwpVost3gBQzSiBDqN3qKfTI2yqzdYn7ug62 Ez7s3gjbjuE5ibI4Q4gb5czgCOGvr69enNxmO4EpxvnEKXtiBzHRHSbabg4tYmuMLBThZU pVBFm73oFwtAEGEOzV+6WbdJ1ZRoFxII5MtYqJBVRMiMxdSvmCRZWNT4bUbmQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 058EA15BDF for ; Wed, 10 Apr 2024 07:54:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruQpT-00084j-MR; Wed, 10 Apr 2024 01:49:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruQpM-00080z-BW for guix-patches@gnu.org; Wed, 10 Apr 2024 01:48:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruQpM-0002MH-1D for guix-patches@gnu.org; Wed, 10 Apr 2024 01:48:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruQpU-0002yI-2p for guix-patches@gnu.org; Wed, 10 Apr 2024 01:49:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70158] [PATCH 0/6] Scilab: Fixup install of local Scilab packages. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Apr 2024 05:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70158 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Elsing Cc: 70158@debbugs.gnu.org Received: via spool by 70158-submit@debbugs.gnu.org id=B70158.171272811611210 (code B ref 70158); Wed, 10 Apr 2024 05:49:03 +0000 Received: (at 70158) by debbugs.gnu.org; 10 Apr 2024 05:48:36 +0000 Received: from localhost ([127.0.0.1]:51887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruQp2-0002uh-2b for submit@debbugs.gnu.org; Wed, 10 Apr 2024 01:48:36 -0400 Received: from 3.mo576.mail-out.ovh.net ([188.165.52.203]:57473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruQov-0002tE-7d for 70158@debbugs.gnu.org; Wed, 10 Apr 2024 01:48:33 -0400 Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.148.87]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4VDsLn4mtCz1fY1 for <70158@debbugs.gnu.org>; Wed, 10 Apr 2024 05:48:17 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-66rnv (unknown [10.108.54.69]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 447EF1FDC3; Wed, 10 Apr 2024 05:48:17 +0000 (UTC) Received: from ngraves.fr ([37.59.142.107]) by ghost-submission-6684bf9d7b-66rnv with ESMTPSA id UCbpCCEoFmb2AwAAs2hl1g (envelope-from ); Wed, 10 Apr 2024 05:48:17 +0000 X-OVh-ClientIp: 81.67.146.208 In-Reply-To: <8634rv5vwj.fsf@posteo.net> References: <8634rv5vwj.fsf@posteo.net> Date: Wed, 10 Apr 2024 07:48:16 +0200 Message-ID: <87seztdazj.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 2891592435960832736 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrudehhedgleeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepveekleeujedthefgffekleekhffhffetgfdvheekleeuhfehueeljedtjefhvdfgnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrddutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejtdduheekseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehjeeipdhmohguvgepshhmthhpohhuth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.87 X-Spam-Score: -6.87 X-Migadu-Queue-Id: 058EA15BDF X-Migadu-Scanner: mx13.migadu.com X-TUID: VTJfH1OxURqh On 2024-04-08 22:31, David Elsing wrote: > Hi Nicolas, > > I'm not really familiar with Scilab itself, I worked on the package to > update the SuiteSparse dependency and noticed that many files were > autogenerated. Thanks for your review David. > > Here are some comments about your patches: > - I think patches 1, 2 and 4 can be combined, as well as patches 3, 5 > and 6, or was there a reason to split them? 6 is separate from 3 and 5, I'll merge the other though, thanks! > - For patch 4, I don't think you need to mention how many lines are > saved in the commit message. :) DONE > - For patches 5 and 6, my impression was that patch files should have a > comment and mention the upstream status if relevant. Maybe you can > additionally make a merge request upstream for them, as they do not > seem specific to Guix? Patch files should also be registered in > gnu/local.mk. I will. > - `guix lint` mentions that "bash-minimal" should be in 'inputs' when > 'wrap-program' is used. This is relevant for cross builds, but at the > moment, dune-build-system (for OCaml packages) does not support cross > builds anyway. It wouldn't hurt to add bash-minimal anyway though. Thanks, will add that too. > > Otherwise, they look fine to me. > > Cheers, > David -- Best regards, Nicolas Graves