From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qODbE5YSMGaWcAEAqHPOHw:P1 (envelope-from ) for ; Mon, 29 Apr 2024 23:35:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qODbE5YSMGaWcAEAqHPOHw (envelope-from ) for ; Mon, 29 Apr 2024 23:35:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lJJQfhE2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714426518; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vpwZtMyqCiFX4daQN5z2+VHFbyT316xkoiEKReOjluw=; b=WEubQSNBbtVT4KY4Ic8PBjBP7TX+jklopJ5Dg5blc9qLNzENqGmXb+/E+ohUKlXf/jiF80 iaHVkJ1fw3JXmS/kZt633jXM3OsAX39a7Py1FRY9a4opRjfYwvOCS651kaVbXO4qzI0eCJ 44e++YZ5yaLE+Zpu0WERmGcur7TYeob2HJnAJkGUx+QNphDwvJe5WD06gQSzCdKP56+Jhf 8s3iec2icJ/URP8gOXLjRTeHhDVhb+cYzQpUObf0EalJrXwNA23SaelbKWnrchsbIbwEfj OTGmotfaDzjVsHTw0s1rmsm47CIOqaovvFGGy6kqGiWa5Ti7luyJ6AhbDJJPXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lJJQfhE2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714426518; a=rsa-sha256; cv=none; b=RR42z/2/5TGWJ3uWRMZQaenShAdy4uk6WaxfaskGdPbfzgS2+YWMBEjLcLNDXrVn7KCIk1 BbSAp5kzIFSfgsz2esrYWX1NQ/4S/moZ++snTwtHGTLNzsbn+6JFEPRgnPL80SGm3u9rwB +1rJyLqpvlnKuWvrZ7G8qA1ddbrZmh4gTycnxdGvSwevCXp2igUPdYJ2l/2vdXCubfF1j6 k4oD3zbaQ/nVp4KcQV4L5y8Ik1YNTXcOuWJT+HkobjGaVRgTBX15adZs6KlYHQR0jE5Jza Ig8u/Y6GuLeJR/QzpfW48idVcpP2f6y6XVP7btbGxfAxlkS/+7LoXPsixiwWIw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14EFE145A0 for ; Mon, 29 Apr 2024 23:35:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1YeQ-00056I-Il; Mon, 29 Apr 2024 17:35:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Ye2-0004Ji-Lg for guix-patches@gnu.org; Mon, 29 Apr 2024 17:34:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1Ye2-0003rT-9G for guix-patches@gnu.org; Mon, 29 Apr 2024 17:34:42 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s1YeM-0003VS-31 for guix-patches@gnu.org; Mon, 29 Apr 2024 17:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70285] [PATCH 2/3] services: cuirass: Add new configuration options. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Apr 2024 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ahmad Draidi Cc: 70285@debbugs.gnu.org Received: via spool by 70285-submit@debbugs.gnu.org id=B70285.171442644713461 (code B ref 70285); Mon, 29 Apr 2024 21:35:02 +0000 Received: (at 70285) by debbugs.gnu.org; 29 Apr 2024 21:34:07 +0000 Received: from localhost ([127.0.0.1]:58830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1YdS-0003V3-Qi for submit@debbugs.gnu.org; Mon, 29 Apr 2024 17:34:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1YdP-0003Ug-8T for 70285@debbugs.gnu.org; Mon, 29 Apr 2024 17:34:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Ycw-0003mw-59; Mon, 29 Apr 2024 17:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=vpwZtMyqCiFX4daQN5z2+VHFbyT316xkoiEKReOjluw=; b=lJJQfhE2fbzVDTI+Yzw6 8HPQw2APNDlVoultCNEu5eU2ZZdPKN7lh6uU9DkAYevtl6KlfsxUnPrZ6aAMXoyM4rqg6zMkPsKJo s9apPM2Psd6sYchzphKI1v5wHvB7lDi4uVe/CRtiBk5nYB/ZWd+HUa8EUZD/Zg1Kwkoak22ETyZlU 7+1ahkSRkW8EidjsFF3ZdM/mlUuGpvtHZAfQiHujGn0vP3cajxPuxXSjvntf5kjSS+c5bGpbgXyZS oXG6Z9q73zm4feqgrPmFr/dSxS6nKw88Ne4dW/S0Ac9rNxI2weRlJdAEQQQg2pmUn+JkiFpqy0B8R /kxH/l2vuwXQaQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <7ccac410c5f7d0c9b27c828bc088c485f22884a8.1712576504.git.a.r.draidi@redscript.org> (Ahmad Draidi's message of "Mon, 8 Apr 2024 21:54:13 +0400") References: <7ccac410c5f7d0c9b27c828bc088c485f22884a8.1712576504.git.a.r.draidi@redscript.org> Date: Mon, 29 Apr 2024 23:33:31 +0200 Message-ID: <87sez3zwes.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.09 X-Spam-Score: -7.09 X-Migadu-Queue-Id: 14EFE145A0 X-Migadu-Scanner: mx13.migadu.com X-TUID: ZjllCu2tSQvw Hi Ahmad, Ahmad Draidi skribis: > * gnu/services/cuirass.scm (): Add ttl and threads > fields. > (cuirass-shepherd-service): Handle the new options. > * doc/guix.texi (Continuous Integration): Document them. [...] > + (ttl cuirass-configuration-ttl ;string > + (default "30d")) For consistency with , I would make it an integer (number of seconds). If that=E2=80=99s fine with you, could you send an updated patch or let me = know if I should make this change on your behalf? The rest of the patch series looks good to me! Thanks, Ludo=E2=80=99.