From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2EXMJJFIX2ZjIwEAe85BDQ:P1 (envelope-from ) for ; Tue, 04 Jun 2024 19:02:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2EXMJJFIX2ZjIwEAe85BDQ (envelope-from ) for ; Tue, 04 Jun 2024 19:02:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SsQNZWdn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717520529; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=xgZgQV4mOfjqzTcj2nvNgkbxq7lP49HLTLZZ5sWJcx0=; b=TuX9Jr1oGjb7iucbxZzhhk6IEXXSKFnsS1G4GVDk62L3Dg1o9gsV98b+98hLFSCUrd/KKA 5SSdzn+FzYt7Q3deTFm0rbhWf1JI2OgLVNTDKFFNDd34xN2q7zOr5c8faC5jffn5noDXat fC7iZEZ8xJJtz6wpUW3p7MzPrsV+v+pOyiPHdhBZwU0QBBW2m0EGs9mJdZ1c3ildE8mnFF Z4aRvuM4+3gV96WMC7FBNau1sHdf3vo6AbpUCUZIOPIuiGaQ70ueI2lzghF0kB0/KR5Lyu IwSXmTjmTNFbql+UlkIRIfbpFWNtSx9694wRaI0VObBQ+JMWBiiuc5VfIByYbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717520529; a=rsa-sha256; cv=none; b=TAhg2/n6n+0lrCtE5pnXu9tRoptHWpADEKfOdOrm6b7l0kwPTkEKzT0VpKVjd014aAPBOw NGcdNl3LaI93aYzRNfEycQrb06ODJHBOi36FcgbGj0+jD8uVT6jyVIKQnNnKjdL6yZ41uL wiEgb0xi4YDCpFkzARtJhiTuKItbwSFsy95k8KflQpZC5zDZCritaqY3VFH/fCed+UNS1x TwUiM/iANQ+zVP7DCSlI5Cc8c+o5os8b0NFGKZDRGrmtenKAnKIevKnDaAa3t/uKai7chO 9NWr8cgQqNFihMZSb4oGJpRchL4dZJquv2y24qnTrXd7QyvlP5cLDYqOf9KbLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SsQNZWdn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46E357819A for ; Tue, 04 Jun 2024 19:02:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEXXk-0002Ry-Is; Tue, 04 Jun 2024 13:01:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEXXg-0002Qj-P5 for guix-patches@gnu.org; Tue, 04 Jun 2024 13:01:50 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEXXg-0007bS-Em for guix-patches@gnu.org; Tue, 04 Jun 2024 13:01:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEXXt-0001D3-If for guix-patches@gnu.org; Tue, 04 Jun 2024 13:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71023] [PATCH 0/9] Update fzf to 0.52.1 References: In-Reply-To: Resent-From: Luis Henrique Gomes Higino Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Jun 2024 17:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71023 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71023@debbugs.gnu.org Cc: sharlatanus@gmail.com Received: via spool by 71023-submit@debbugs.gnu.org id=B71023.17175204894549 (code B ref 71023); Tue, 04 Jun 2024 17:02:01 +0000 Received: (at 71023) by debbugs.gnu.org; 4 Jun 2024 17:01:29 +0000 Received: from localhost ([127.0.0.1]:38657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEXXM-0001BI-CA for submit@debbugs.gnu.org; Tue, 04 Jun 2024 13:01:28 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:44075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEXXK-0001Ax-IF for 71023@debbugs.gnu.org; Tue, 04 Jun 2024 13:01:27 -0400 Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1f47f07aceaso38079805ad.0 for <71023@debbugs.gnu.org>; Tue, 04 Jun 2024 10:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717520407; x=1718125207; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=xgZgQV4mOfjqzTcj2nvNgkbxq7lP49HLTLZZ5sWJcx0=; b=SsQNZWdnI1T8ftea37v91nf7VsEY5EMo8gFvIQUeHUgPqFWzzim+m2ajpwSbHFyqaJ ebH1Gz2WolI7/qHBAZhKjZBbovqUGj4ovvd5HTJ3Fj6TXG5JxBkKt/3yWjzWdsSABIH8 vj53E2T+/QRkVKmmqvrIO7KS8zMMquZ6Jixxq1HM+yLH+QhfzfYBPy5pHQgp67hxdk3v FYwI6QUnNUPc+zlGmoxVL15h+gNH+Fc11d/HH3F7JObLuocl1QlID6BwWQXOTqVRE/Hc Y/Wf6hpRTBwPYY6YHTArN8a8Q2ngpeMvao0DSLWQrBu3YtGO9zCzOO0tyV+THQ5+T6LR e6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717520407; x=1718125207; h=mime-version:message-id:date:user-agent:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xgZgQV4mOfjqzTcj2nvNgkbxq7lP49HLTLZZ5sWJcx0=; b=cayfhR2uWpCFyIKmk7MyaVOvNcjBR38wYuhywTOLszu2owAHFT5R2pvGowPqWfRfKI VA1/UyVTjI1bJUpfb+SaMuNq8k3j2oA2FArWzmh7dJrPhbq98T+IJqcn5yBP4lXTFqan im8f1lVEG0gIJnLnWwkSPwVUqKoBxUR2LiTyhj98SaLlWE5KCfksR3NH6EgKBalS7ZGt 7qmkaYf+KpWJHlIgeMPZFqMmloCvWbMfSC80Y0L8mUpyFQvfDLjc+Ydqd/MSbixTCeNz cLi1U0zRjolpoxXF83TYVjYl5WvDjQe0m89GRyWLua6Zse7JNYcH2EuuxFf5vkRrwFs3 Aldg== X-Gm-Message-State: AOJu0YzpLhEUfUwD36LFWg7FfjVQN7S9NaBXK/j75n49RkEVyycBluzt yaDvEbI8haEPN9gCP/yaOXsCwpxAq4aTwV0LwATTGdyIOO57gEYx X-Google-Smtp-Source: AGHT+IG6SNFg6VtTKockOfrnzMLcultiXECbnRSUxJkWcH41fWWR/vdS/DdS3nhS8NzPFtIKTbjrbQ== X-Received: by 2002:a17:902:ea06:b0:1f6:2964:179e with SMTP id d9443c01a7336-1f6a5a0e773mr922825ad.23.1717520406815; Tue, 04 Jun 2024 10:00:06 -0700 (PDT) Received: from asusdebian ([200.238.196.60]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323e9f20sm85536265ad.189.2024.06.04.10.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 10:00:06 -0700 (PDT) From: Luis Henrique Gomes Higino User-Agent: mu4e 1.12.4; emacs 29.3 Date: Tue, 04 Jun 2024 17:00:00 +0000 Message-ID: <87sexs8wz3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.74 X-Spam-Score: -0.74 X-Migadu-Queue-Id: 46E357819A X-Migadu-Scanner: mx11.migadu.com X-TUID: 8STCCpcYDRst --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; format=flowed Hi Oleg, > From the first glance, some of the changes need to be grouped as > single commit - [PATCH 8/9] gnu: golang.scm: Update packages and > go versions. thanks for the feedback! I didn't know it was OK to group commits, do you think all commits before the last one should be grouped? > A general cement to all of them - is everything related just to > bump fzf to the latest version or it's a collection of not > related patches? So, to upgrade fzf I had to update some of its dependencies and, due to it, had to update their go versions from 17 to 18. When I checked if any other dependent packages were affected with =guix refresh=, it showed to me that the packages were not building because they were compiled with Go 17 and it seems the =go-build-system= vendorizes all package dependencies before building. I tried fixing only the packages that were broken, so I guess they are all related in that sense. I'm totally open to being convinced otherwise though :) > Also try to avoid adding any new packages to golang.scm. OK, I read some other packages there and it seemed to me that =fastwalk= was similar in nature to the ones near it (where I inserted it). Should I move it to =golang-xyz.scm= instead? --==-=-= Content-Type: text/html

Hi Oleg,

From the first glance, some of the changes need to be grouped as single commit - [PATCH 8/9] gnu: golang.scm: Update packages and go versions.

thanks for the feedback! I didn't know it was OK to group commits, do you think all commits before the last one should be grouped?

A general cement to all of them - is everything related just to bump fzf to the latest version or it's a collection of not related patches?

So, to upgrade fzf I had to update some of its dependencies and, due to it, had to update their go versions from 17 to 18. When I checked if any other dependent packages were affected with guix refresh, it showed to me that the packages were not building because they were compiled with Go 17 and it seems the go-build-system vendorizes all package dependencies before building. I tried fixing only the packages that were broken, so I guess they are all related in that sense. I'm totally open to being convinced otherwise though :)

Also try to avoid adding any new packages to golang.scm.

OK, I read some other packages there and it seemed to me that fastwalk was similar in nature to the ones near it (where I inserted it). Should I move it to golang-xyz.scm instead?

--==-=-=-- --=-=-= Content-Type: text/plain -- Luis H. Higino --=-=-=--