unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#71361] [PATCH] gnu: rust-dns-lookup-2: fix package test.
@ 2024-06-04 12:06 picnoir
  2024-06-10 10:10 ` bug#71361: " Christopher Baines
  0 siblings, 1 reply; 2+ messages in thread
From: picnoir @ 2024-06-04 12:06 UTC (permalink / raw)
  To: 71361; +Cc: Picnoir, Efraim Flashner

From: Picnoir <picnoir@alternativebit.fr>

* gnu/packages/crates-io.scm (rust-dns-lookup-2): this package was introduced
in abfef465b2b2353610cbff2caefee679566978f7 as a dependency for Nsncd. We can
build Nsncd just fine, but building explicitely this package is failing. The
issue comes from two tests making assumption about domain name resolution. The
Guix build sandbox breaks these assumptions, preventing the test suite to
succeed. Fixing this by disabling the faulty tests.

Change-Id: Idc42822d8cd72e83e9ea973820b5073ff87ad4d4
---
 gnu/packages/crates-io.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 47c280e79f..5c9bc4c525 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -19955,7 +19955,12 @@ (define-public rust-dns-lookup-2
         (base32 "1z74n2zij2gahycabm0gkmkyx574h76gwk7sz93yqpr3qa3n0xp5"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs (("rust-cfg-if" ,rust-cfg-if-1)
+     `(#:cargo-test-flags
+       '("--"
+         ;; the builder sandbox breaks getaddrinfo, failing two tests.
+         "--skip=nameinfo::test_getnameinfo"
+         "--skip=src/lib.rs")
+       #:cargo-inputs (("rust-cfg-if" ,rust-cfg-if-1)
                        ("rust-libc" ,rust-libc-0.2)
                        ("rust-socket2" ,rust-socket2-0.5)
                        ("rust-windows-sys" ,rust-windows-sys-0.48))))

base-commit: 5d3edff1a604414a3c42b89fcbc007e9d573993d
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#71361: [PATCH] gnu: rust-dns-lookup-2: fix package test.
  2024-06-04 12:06 [bug#71361] [PATCH] gnu: rust-dns-lookup-2: fix package test picnoir
@ 2024-06-10 10:10 ` Christopher Baines
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2024-06-10 10:10 UTC (permalink / raw)
  To: picnoir; +Cc: 71361-done, Efraim Flashner

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

picnoir@alternativebit.fr writes:

> From: Picnoir <picnoir@alternativebit.fr>
>
> * gnu/packages/crates-io.scm (rust-dns-lookup-2): this package was introduced
> in abfef465b2b2353610cbff2caefee679566978f7 as a dependency for Nsncd. We can
> build Nsncd just fine, but building explicitely this package is failing. The
> issue comes from two tests making assumption about domain name resolution. The
> Guix build sandbox breaks these assumptions, preventing the test suite to
> succeed. Fixing this by disabling the faulty tests.
>
> Change-Id: Idc42822d8cd72e83e9ea973820b5073ff87ad4d4
> ---
>  gnu/packages/crates-io.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Thanks! I've pushed this to master as
7b0970fb4386726519204b74230b563ad060741b.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-10 20:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 12:06 [bug#71361] [PATCH] gnu: rust-dns-lookup-2: fix package test picnoir
2024-06-10 10:10 ` bug#71361: " Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).