From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id EHmwEWpajGaZTQAA62LTzQ:P1 (envelope-from ) for ; Mon, 08 Jul 2024 21:30:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id EHmwEWpajGaZTQAA62LTzQ (envelope-from ) for ; Mon, 08 Jul 2024 23:30:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=Y86+XPue; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720474218; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wTv5MXWVQepvsug59lbooDTnGh3HpaKALb9vQwXTfgE=; b=W2Lo34xYK3kuHXbLJ7HlYdJxc14QeaRlEfTw0lsJfmL2YUJ10ZPKVfc7HDl6Zx+1A9pJve xWq/1RGbvDyr0lSH7ucMWxnI9qN+5G0fZ+k+iphg3EPmnMe2UXoCFrsWlf0Z1I4WOJfzwk MLIE7uEGjT/GJH4PXNrFjuq03GYJ7RMe1/CBSjoFueKG+fWoCIAxHZVURMwUCRYfrTZAsB K7nQRyDzv+g7lAhO/9inwrthimHz0Pbgwa4DP13ImuXUdt5w4sNXSsyFfnAPc3XqEhAgTo chL/qPwlS8JWszHcxZkl9Td56MCTr1MQo/F6vjPNHLCIay4SmApT+sUPWUBG5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720474218; a=rsa-sha256; cv=none; b=on7wwSn/LoiMqvN8nPJjxr8bcXrlBKEyreSFjXJ0nUOh5ImJDziyrg9JxpATp/nNL+JIyM PiB6ZUCdbRezDIsIsd4U8bfiiHe/iCwkB4VFZa8dmyu7AVvgU+eVKzDeN4RixLYXlv/IhM y1zZMb0dpgDSReb7pa5/eDtysxn7GxfxPIwHPITi9O4Ypm8/0UmCUl9TkqyUBBdc06iZR4 pNsPoH7c7RRGQYHHvXFp5o0G7crOlWgPfAP9MkGqYvEbE8cEhORDFrmjM8zFsdKi6Y8uOF VHSkhrTwUK1SRNbRqiXAPw7vM9vy3S2UDsgQtEVrc0LG81s36/JGAz7Z6l/HAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=Y86+XPue; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0ABC673005 for ; Mon, 08 Jul 2024 23:30:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQvvq-00024M-TO; Mon, 08 Jul 2024 17:29:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQvvp-000249-GC for guix-patches@gnu.org; Mon, 08 Jul 2024 17:29:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQvvp-0000LG-77 for guix-patches@gnu.org; Mon, 08 Jul 2024 17:29:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQvvt-0003CV-UP for guix-patches@gnu.org; Mon, 08 Jul 2024 17:30:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. References: Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jul 2024 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69074@debbugs.gnu.org Cc: Troy Figiel , jgart , =?UTF-8?Q?S=C3=B6ren?= Tempel Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.172047416612232 (code B ref 69074); Mon, 08 Jul 2024 21:30:01 +0000 Received: (at 69074) by debbugs.gnu.org; 8 Jul 2024 21:29:26 +0000 Received: from localhost ([127.0.0.1]:51614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQvvJ-0003BE-VV for submit@debbugs.gnu.org; Mon, 08 Jul 2024 17:29:26 -0400 Received: from mx2.dismail.de ([159.69.191.136]:45210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQvvF-0003Au-V4 for 69074@debbugs.gnu.org; Mon, 08 Jul 2024 17:29:24 -0400 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 8f43d6b9; Mon, 8 Jul 2024 23:29:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=20190914; bh=uY13gCmHr2dBLxTDWOzI8vGBGuAM0WbLv9GDS4ezEgo=; b= Y86+XPueeW+L12b+lLyqfbJgquKVe9hUYRlKBkw5rzmE+wqpgj2aqY0dyBqT7hZa rZ1RyoKTajhbOzTReQFgnrXeDQgycbCKzzb+kIs541ys4yXqs1zjXNqxDLytRHDi EKrEwz/N7VAqhZ1pYi4nkV40ckWtODAgVVqEAPCwNoUJCGzLJMCnRK4VxH5yB7Vp RdvVds42bD8ndII8aMYQAy/j2gMbjyqCRR6H98T00lHh/542oxsc31K2lcXAxKep gq9n/5YsIU7tbOs9zEGmOdtKn2pLCI51OUBJbhXjS/H73MFkbqeU/WCPJBWU7Rp8 9F2muWslJ88IldQS6cEG7g== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx2.dismail.de (OpenSMTPD) with ESMTP id b96365bb; Mon, 8 Jul 2024 23:29:08 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id cdc48164; Mon, 8 Jul 2024 23:29:08 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 4a5737d6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 8 Jul 2024 23:29:07 +0200 (CEST) In-Reply-To: <2Z5WA5IA96MHL.3CMTOHDZJPPDF@8pit.net> Date: Mon, 08 Jul 2024 16:29:04 -0500 Message-ID: <87sewjwp27.fsf@dismail.de> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.09 X-Spam-Score: -4.09 X-Migadu-Queue-Id: 0ABC673005 X-Migadu-Scanner: mx11.migadu.com X-TUID: 859THUDFmBky > I was under the impression that I fixed the relevant linker warnings. I > didn't fix the capstone warnings as I only added a patch for capstone > and didn't want to refactor the existing code as part of that (i.e. the > warnings are not introduced by my changes). For python-angr I only get > two "line is way too long"-warnings, both caused by long not easily > breakable strings (e.g. the checksum). > Hi Soeren, > Should I refactor the capstone package as part of this patchset? Could you send just the capstone package in a separate new ticket and CC me? I can review capstone separately. Once that ticket is resolved we can update this ticket and continue the reviewing here for angr with less patches for me to review all at once. My time is limited and I think that this will allow us to progress on this issue. Notice that I changed the package name. The upstream is called *demangler and not *demangle. I also added a note as to why we are not using the PyPI source. If not using the PyPI source we should add a comment as to why not. We prefer PyPI whenever possible for `guix import` tool reasons. Can you send a v2 without python-itanium-demangler in a new patch series? I spent some time reviewing these patches. There's definitely a lot to look at. I applied python-itanium-demangler in this commit: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=789c4037947d59a7143999269791bf75436fdccd Another thing I noticed is that we have this ticket open for pwntools: https://issues.guix.gnu.org/61431 -;; python-pwntools requires a -rc release of unicorn The above line was removed but this patch series leaves pwntools broken. I think we should resolve that here. Also, if there are versions of Python packages that are specifically needed for angr and no other packages depend on them then I think it would be better practice to call them python-foo-for-angr instead of leaving a comment and using the package name python-claripy. For example, python-claripy-for-python-angr. We have similar packages in the guix package collection that follow such a pattern. The latest version of python-claripy is 9.2.109 and you're packaging 9.2.46 with the top-level variable name. Other python team members or guix contributors feel free to comment on this if you have additional feedback. -- all the best, jgart