unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 72396@debbugs.gnu.org
Cc: "Nguyễn Gia Phong" <mcsinyx@disroot.org>
Subject: [bug#72396] [PATCH 1/2] gnu: Add zycore.
Date: Thu, 15 Aug 2024 16:19:28 +0200	[thread overview]
Message-ID: <87sev5eumn.fsf@ngraves.fr> (raw)
In-Reply-To: <254535bd95290fdd6aca4bb5eb1b2e17330a91e3.1722420324.git.mcsinyx@disroot.org>

On 2024-07-31 19:14, guix-patches--- via wrote:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> +    (synopsis "Internal library for Zydis.")

Hi Nguyễn Gia Phong,

A minor nitpick:
zycore@1.5.0: no period allowed at the end of the synopsis

Checking `guix lint` would have told you ;)

Otherwise LGTM, built and rebuilt deterministically.

-- 
Best regards,
Nicolas Graves




  reply	other threads:[~2024-08-15 14:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 10:12 [bug#72396] [PATCH 0/2] gnu: Add zydis guix-patches--- via
2024-07-31 10:14 ` [bug#72396] [PATCH 1/2] gnu: Add zycore guix-patches--- via
2024-08-15 14:19   ` Nicolas Graves via Guix-patches via [this message]
2024-07-31 10:14 ` [bug#72396] [PATCH 2/2] gnu: Add zydis guix-patches--- via
2024-08-18  2:22 ` [bug#72396] [PATCH v2 1/2] gnu: Add zycore guix-patches--- via
2024-08-18  2:23   ` [bug#72396] [PATCH v2 2/2] gnu: Add zydis guix-patches--- via
2024-08-19  6:19     ` Zheng Junjie
2024-08-19  7:54       ` guix-patches--- via
2024-08-19  6:17   ` bug#72396: [PATCH v2 1/2] gnu: Add zycore Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sev5eumn.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=72396@debbugs.gnu.org \
    --cc=mcsinyx@disroot.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).