From: "Ludovic Courtès" <ludo@gnu.org>
To: Homo <gay@disroot.org>
Cc: 74784@debbugs.gnu.org
Subject: [bug#74784] [PATCH] gnu: hugs: Fix build with GCC.
Date: Mon, 16 Dec 2024 00:19:00 +0100 [thread overview]
Message-ID: <87seqofsbf.fsf@gnu.org> (raw)
In-Reply-To: <20241211102636.20121-1-gay@disroot.org> (Homo's message of "Wed, 11 Dec 2024 12:26:36 +0200")
Hi,
Homo <gay@disroot.org> skribis:
> Change-Id: I6bbfb65e62d9a2b1a3c8b29eb386a24d6974eb45
> ---
> gnu/packages/hugs.scm | 7 +++----
> gnu/packages/patches/hugs-fix-build.patch | 21 +++++++++++++++++++++
> 2 files changed, 24 insertions(+), 4 deletions(-)
> create mode 100644 gnu/packages/patches/hugs-fix-build.patch
A couple of minor nits but I think it’ll be useful if you plan to
contribute more:
> --- /dev/null
> +++ b/gnu/packages/patches/hugs-fix-build.patch
> @@ -0,0 +1,21 @@
> +diff --git a/packages/base/include/HsBase.h b/packages/base/include/HsBase.h
> +index aa1a7fb..78d5b46 100644
Could you add a sentence at the top explaining what the patch does?
(This will placate ‘guix lint’ in addition to myself. :-))
Could you also register the file in ‘gnu/local.mk’?
Last, you can use ‘etc/committer.scm’ to generate a commit log or
template thereof that follow the project’s conventions.
Thanks,
Ludo’.
prev parent reply other threads:[~2024-12-15 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 10:26 [bug#74784] [PATCH] gnu: hugs: Fix build with GCC Homo via Guix-patches via
2024-12-15 23:19 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seqofsbf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=74784@debbugs.gnu.org \
--cc=gay@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).