unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#75885] [PATCH] gnu: rofi-pass-wayland
@ 2025-01-27  3:05 Jake Koroman via Guix-patches via
  2025-02-02 13:58 ` Nicolas Graves via Guix-patches via
  2025-02-02 14:45 ` [bug#75885] QA review for 75885 Nicolas Graves via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: Jake Koroman via Guix-patches via @ 2025-01-27  3:05 UTC (permalink / raw)
  To: 75885; +Cc: Jake Koroman

* gnu/packages/password-utils.scm (rofi-pass-wayland): Removed doubled /etc substitute.

The substitute is wrong here as it is already being inherited from the rofi-pass package.
This causes the substitute to run twice and cause an error in the outputted config file.

Change-Id: I61d7ed4f9f84903aef2a21a3bc5ca3e65a092577
---
 gnu/packages/password-utils.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 0a3711b..81758ce 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -1073,10 +1073,7 @@ (define-public rofi-pass-wayland
                        (("#clibpoard_backend=xclip")
                         "clipboard_backend=wl-clipboard")
                        (("#backend=xdotool")
-                        "backend=wtype"))
-                     (substitute* "rofi-pass"
-                       (("/etc")
-                        (string-append #$output "/etc")))))
+                        "backend=wtype"))))
             ;; Use Wayland related tools instead.
             (replace 'wrap-path
               (lambda* (#:key inputs #:allow-other-keys)

base-commit: 5133fe25d4c105ce4bdc7134bc585a1f673d8a8b
-- 
2.47.1






^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#75885] [PATCH] gnu: rofi-pass-wayland
  2025-01-27  3:05 [bug#75885] [PATCH] gnu: rofi-pass-wayland Jake Koroman via Guix-patches via
@ 2025-02-02 13:58 ` Nicolas Graves via Guix-patches via
  2025-02-02 14:45 ` [bug#75885] QA review for 75885 Nicolas Graves via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Graves via Guix-patches via @ 2025-02-02 13:58 UTC (permalink / raw)
  To: 75885; +Cc: Jake Koroman


On 2025-01-27 03:05, Jake Koroman via Guix-patches via wrote:

> * gnu/packages/password-utils.scm (rofi-pass-wayland): Removed doubled
> /etc substitute.

Hi Jake, welcome!
Maybe you could be a little more precise, like that :

[arguments]<#:phases>: Remove code doubling /etc prefix in phase
'set-wayland-defaults.

But that's not a blocker to me.  Tested, marking as LGTM.

-- 
Best regards,
Nicolas Graves




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#75885] QA review for 75885
  2025-01-27  3:05 [bug#75885] [PATCH] gnu: rofi-pass-wayland Jake Koroman via Guix-patches via
  2025-02-02 13:58 ` Nicolas Graves via Guix-patches via
@ 2025-02-02 14:45 ` Nicolas Graves via Guix-patches via
  2025-02-02 21:55   ` bug#75885: " Leo Famulari
  1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Graves via Guix-patches via @ 2025-02-02 14:45 UTC (permalink / raw)
  To: control, 75885

user guix
usertag 75885 + reviewed-looks-good
thanks

Guix QA review form submission:
The commit message could be more precise, but is acceptable IMO. I can confirm the fix claimed indeed happens.

Items marked as checked: Lint warnings, Package builds, Commit messages

-- 
Best regards,
Nicolas Graves




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#75885: QA review for 75885
  2025-02-02 14:45 ` [bug#75885] QA review for 75885 Nicolas Graves via Guix-patches via
@ 2025-02-02 21:55   ` Leo Famulari
  0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2025-02-02 21:55 UTC (permalink / raw)
  To: Nicolas Graves, Jake Koroman; +Cc: 75885-done

On Sun, Feb 02, 2025 at 03:45:06PM +0100, Nicolas Graves via Guix-patches via wrote:
> user guix
> usertag 75885 + reviewed-looks-good
> thanks
> 
> Guix QA review form submission:
> The commit message could be more precise, but is acceptable IMO. I can confirm the fix claimed indeed happens.
> 
> Items marked as checked: Lint warnings, Package builds, Commit messages

Thanks Jake, for identifying the bug and sending a patch to fix it!

I pushed your patch as commit ad59a0c88bac673e1267d928fdfe2e83858d2839
after rewriting the commit message to follow our format and be a little
more informative (in my opinion):

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ad59a0c88bac673e1267d928fdfe2e83858d2839

Nicolas, thanks for the review!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-02 21:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27  3:05 [bug#75885] [PATCH] gnu: rofi-pass-wayland Jake Koroman via Guix-patches via
2025-02-02 13:58 ` Nicolas Graves via Guix-patches via
2025-02-02 14:45 ` [bug#75885] QA review for 75885 Nicolas Graves via Guix-patches via
2025-02-02 21:55   ` bug#75885: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).