From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8YoA-0003DF-3i
	for guix-patches@gnu.org; Wed, 10 May 2017 17:06:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8Yo6-0006i3-MQ
	for guix-patches@gnu.org; Wed, 10 May 2017 17:06:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34565)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d8Yo6-0006hs-Ht
	for guix-patches@gnu.org; Wed, 10 May 2017 17:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8Yo6-000650-Bg
	for guix-patches@gnu.org; Wed, 10 May 2017 17:06:02 -0400
Subject: bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images.
Resent-Message-ID: <handler.26815.B26815.149445035223354@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87efvzl7w8.fsf@gnu.org>
	<20170510195227.13461-1-mbakke@fastmail.com>
	<20170510195227.13461-3-mbakke@fastmail.com>
Date: Wed, 10 May 2017 23:05:35 +0200
In-Reply-To: <20170510195227.13461-3-mbakke@fastmail.com> (Marius Bakke's
	message of "Wed, 10 May 2017 21:52:27 +0200")
Message-ID: <87r2zwqv6o.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26815@debbugs.gnu.org

Hi Marius,

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/system/vm.scm (qemu-image): Add GRUB-EFI to inputs. Append 40MiB EFI
> System Partition.
> * gnu/build/vm.scm (install-efi): New procedure.
> (initialize-hard-disk): Generate grub EFI blob when ESP is present.

[...]

> +(define (install-efi esp grub.cfg)
> +  "Write a self-contained Grub UEFI blob to the mounted ESP using GRUB.C=
FG."

I=E2=80=99m really nitpicking here, but the spelling is =E2=80=9CGRUB=E2=80=
=9D.  :-)

> +        (with-output-to-file grub.cfg
> +          (lambda _
> +            (format #t
> +                    "insmod part_msdos~@

Nitpicking too, but I have a preference for the more explicit:

  (call-with-output-file grub.cfg
    (lambda (port)
      (format port =E2=80=A6)))

Otherwise the whole series LGTM.

Do I get it right that =E2=80=98disk-image=E2=80=99 will now give us UEFI-e=
nabled
images?  (Should we mention it in guix.texi?)

Thanks a lot!

Ludo=E2=80=99.