From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 27767@debbugs.gnu.org
Subject: [bug#27767] [PATCH] gnu: Add eolie.
Date: Thu, 20 Jul 2017 12:02:36 +0200 [thread overview]
Message-ID: <87r2xbxw77.fsf@gnu.org> (raw)
In-Reply-To: <20170719215609.15359-1-rekado@elephly.net>
Hi Ricardo!
I guess I'm too late, but here are some comments.
Ricardo Wurmus writes:
> * gnu/packages/gnome.scm (eolie): New variable.
> ---
> gnu/packages/gnome.scm | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 345dc6a74..be00fcff5 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3886,6 +3886,67 @@ the same backend as XSANE uses. This means that all existing scanners will
> work and the interface is well tested.")
> (license license:gpl3+)))
>
> +(define-public eolie
> + (package
> + (name "eolie")
> + (version "0.9.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/gnumdk/eolie/"
> + "releases/download/"
> + (version-major+minor version)
> + "/eolie-" version ".tar.xz"))
> + (sha256
> + (base32
> + "1lb3rd2as12vq24fcf9nmlhggf8vka3kli2i92i8iylwi7nq5n2a"))))
> + (build-system glib-or-gtk-build-system)
> + (arguments
> + `(#:modules ((guix build glib-or-gtk-build-system)
> + (guix build utils)
> + (ice-9 match))
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'wrap 'wrap-more
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + ;; These libraries must be on LD_LIBRARY_PATH.
> + (libs '("gtkspell3" "webkitgtk" "libsoup" "libsecret"
> + "atk" "gtk+" "gsettings-desktop-schemas"
> + "gobject-introspection"))
> + (path (string-join
> + (map (lambda (lib)
> + (string-append (assoc-ref inputs lib) "/lib"))
> + libs)
> + ":")))
> + (wrap-program (string-append out "/bin/eolie")
> + `("LD_LIBRARY_PATH" ":" prefix (,path))
This makes it work, but is this something we want to do here?
There seems to be a deeper issue with how libraries are found.
> + `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))
> + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))
> + #t)))))
> + (native-inputs
> + `(("intltool" ,intltool)
> + ("itstool" ,itstool)
> + ("pkg-config" ,pkg-config)))
> + (inputs
> + `(("gobject-introspection" ,gobject-introspection)
> + ("glib-networking" ,glib-networking)
> + ("cairo" ,cairo)
> + ("gtk+" ,gtk+)
> + ("atk" ,atk) ; propagated by gtk+, but we need it in LD_LIBRARY_PATH
> + ("python" ,python-wrapper)
> + ("python-pygobject" ,python-pygobject)
> + ("python-pycairo" ,python-pycairo)
> + ("libsecret" ,libsecret)
> + ("gtkspell3" ,gtkspell3)
> + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> + ("webkitgtk" ,webkitgtk)))
> + (home-page "https://github.com/gnumdk/eolie/")
> + (synopsis "Web browser for GNOME")
> + (description
> + "Eolie is a new web browser for GNOME. It features Firefox sync support,
> +a secret password store, an adblocker, and a modern UI.")
> + (license license:gpl3+)))
> +
> (define-public epiphany
> (package
> (name "epiphany")
I tested the browser and it seems to work quite well, except for:
- Ads are not blocked, even when the "Block ads" checkbox is checked.
- It seems to be cloning a repository for adblock_js when running the program:
roel@antelope ~/sources/guix$ /gnu/store/ccvdhd5159qkachbzf4y9k5c6ds4cn4n-eolie-0.9.0/bin/eolie
Cloning into '/home/roel/.local/share/eolie/adblock_js'...
Could not initialize PyGObjectremote: Counting objects: 74, done.
remote: Total 74 (delta 0), reused 0 (delta 0), pack-reused 74
Unpacking objects: 100% (74/74), done.
The 'remote' for this repository is:
https://github.com/gnumdk/eolie-adblock.git
- I get a couple of Gtk-WARNINGs:
(eolie:4447): Gtk-WARNING **: Duplicate child name in GtkStack: submenu
(eolie:4447): Gtk-WARNING **: Failed to fetch network locations: Automount failed: Message recipient disconnected from message bus without replying
(eolie:4447): Gtk-WARNING **: Duplicate child name in GtkStack: submenu
(eolie:4447): Gtk-WARNING **: Failed to fetch network locations: Automount failed: Message recipient disconnected from message bus without replying
(eolie:4447): Gtk-WARNING **: Duplicate child name in GtkStack: submenu
(eolie:4447): Gtk-WARNING **: Failed to fetch network locations: Automount failed: Message recipient disconnected from message bus without replying
Application::__on_forms_filled(): g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Name "org.gnome.Eolie.Proxy.Page1" does not exist (3)
- And a couple of more warnings:
Could not initialize PyGObjectApplication::__on_forms_filled(): g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Name "org.gnome.Eolie.Proxy.Page1" does not exist (3)
Could not initialize PyGObject
(eolie:4918): Gtk-WARNING **: Duplicate child name in GtkStack: submenu
Hopefully we can address these things in the future.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2017-07-20 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 21:56 [bug#27767] [PATCH] gnu: Add eolie Ricardo Wurmus
2017-07-20 0:50 ` rennes
2017-07-20 6:42 ` bug#27767: " Ricardo Wurmus
2017-07-20 10:02 ` Roel Janssen [this message]
2017-07-20 13:15 ` [bug#27767] " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2xbxw77.fsf@gnu.org \
--to=roel@gnu.org \
--cc=27767@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).