From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45715)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dbo4j-0000dZ-Ie
	for guix-patches@gnu.org; Sun, 30 Jul 2017 09:16:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dbo4g-0004Z3-EH
	for guix-patches@gnu.org; Sun, 30 Jul 2017 09:16:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59293)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dbo4g-0004Yp-AR
	for guix-patches@gnu.org; Sun, 30 Jul 2017 09:16:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dbo4f-0002Rx-VE
	for guix-patches@gnu.org; Sun, 30 Jul 2017 09:16:01 -0400
Subject: [bug#27865] [PATCH 2/3] pull: Fetch source code from Git.
Resent-Message-ID: <handler.27865.B27865.15014205319376@debbugs.gnu.org>
References: <20170728204539.21879-1-ludo@gnu.org>
	<20170728204539.21879-2-ludo@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170728204539.21879-2-ludo@gnu.org>
Date: Sun, 30 Jul 2017 15:15:21 +0200
Message-ID: <87r2wy83rq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27865@debbugs.gnu.org


Hi Ludo,

Nice job ! Error code handling in git is really a welcome addition too
:)

> +    ((? integer? error)                           ;old Guile-Git
> +     (leave (G_ "Git error ~a~%") error))
> +    ((? git-error? error)                         ;new Guile-Git
> +     (leave (G_ "Git error: ~a~%") (git-error-message error)))))

If an old Guile-Git (without error support) is used git-error? and
git-error-message won't be available anyway, so it is really necessary
to test for an integer ?

I'll use the same piece of code in Cuirass soon.

Thanks,

Mathieu