From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlFxv-0006v6-GL for guix-patches@gnu.org; Fri, 25 Aug 2017 10:52:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlFxq-00082t-Lp for guix-patches@gnu.org; Fri, 25 Aug 2017 10:52:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlFxq-00082p-ID for guix-patches@gnu.org; Fri, 25 Aug 2017 10:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlFxq-00034N-Ay for guix-patches@gnu.org; Fri, 25 Aug 2017 10:52:02 -0400 Subject: [bug#27907] [PATCH] graph: Provide access to the package record in the emit Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgn3w0n6.fsf@gnu.org> <87inhchab4.fsf@gnu.org> Date: Fri, 25 Aug 2017 16:50:52 +0200 In-Reply-To: (Roel Janssen's message of "Fri, 25 Aug 2017 11:00:51 +0200") Message-ID: <87r2vzg0qb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Roel Janssen Cc: 27907@debbugs.gnu.org Roel Janssen skribis: > Oops! I am sorry about this. Would it not break if we include a check f= or whether > the node type is a package or not. Then, non-package node types are > handled the =E2=80=9Cold way=E2=80=9D and packages are handled the =E2=80= =9Cnew way=E2=80=9D. > > I think we cannot have a generic way of exposing the specifics of a node > type, so if we need to expose more information for the other node types, > we have to add a type-specific implementation. Actually, we might need to discuss the specifics of why you wanted to do it in the first place. :-) It is to pass extra rendering info to the backends? (It would be helpful for instance to adjust the node color or size depending on certain parameters such as its size or number of dependents.) > If this sounds like a good idea I'll write a new patch. And while I'm > at it, what set of commands fully cover the graph code for all node > types? Just all variants in 'guix graph --type=3DX'? =E2=80=9Cmake check TESTS=3Dtests/graph.scm=E2=80=9D covers all the node ty= pes I think. Ludo=E2=80=99.