From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 28055@debbugs.gnu.org
Subject: [bug#28055] [WIP] Add knot tests
Date: Tue, 26 Sep 2017 10:27:00 +0200 [thread overview]
Message-ID: <87r2ut27cb.fsf@gnu.org> (raw)
In-Reply-To: <87tw17khg0.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 16 Aug 2017 11:09:03 +0200")
Howdy,
Ricardo Wurmus <rekado@elephly.net> skribis:
>> This patch aims at adding a system test for knot. I've implemented the
>> DNS protocol to be able to communicate with the server and try some
>> queries. Unfortunately, although the server seems to be launched (the
>> first test passes), it then refuses to answer. Do you see anything
>> wrong, or anything I could do to understand why it doesn't pass?
>
> It looks like overkill to implement DNS queries with bytevectors from
> the ground up. Is there not an easier way to make a DNS test?
It’s a bit overkill indeed… but I like it. :-)
Julien: could you move the DNS code to a new module, say (guix dns), and
then add the Knot test?
(So first patch adds (guix dns), second patch adds the test.)
In passing, for (guix dns) it would be nice if you could add docstrings
as you see fit, and attempt to use full words in identifiers (“address”
rather than “addr”, “resolve” rather than “resolv”, etc.¹).
This looks really nice, thanks for working on it!
Ludo’.
¹ https://www.gnu.org/software/guix/manual/html_node/Formatting-Code.html
next prev parent reply other threads:[~2017-09-26 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 19:04 [bug#28055] [WIP] Add knot tests Julien Lepiller
2017-08-16 9:09 ` Ricardo Wurmus
2017-08-16 13:02 ` Julien Lepiller
2017-09-26 8:27 ` Ludovic Courtès [this message]
2017-12-01 10:23 ` Ludovic Courtès
2017-12-02 11:18 ` Julien Lepiller
2017-12-15 10:53 ` Ludovic Courtès
2022-01-13 15:12 ` zimoun
2022-03-23 10:48 ` zimoun
2022-06-23 9:55 ` zimoun
2022-09-18 18:28 ` Julien Lepiller
2023-10-23 21:00 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ut27cb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28055@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).