From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e45FY-0005gN-5c for guix-patches@gnu.org; Mon, 16 Oct 2017 09:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e45FS-0004Rd-4L for guix-patches@gnu.org; Mon, 16 Oct 2017 09:16:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e45FS-0004RK-0x for guix-patches@gnu.org; Mon, 16 Oct 2017 09:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e45FR-00052t-Jd for guix-patches@gnu.org; Mon, 16 Oct 2017 09:16:01 -0400 Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support. Resent-Message-ID: From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: <20171015151545.024a589f@uwaterloo.ca> <20171015200328.4830-2-ajpatter@uwaterloo.ca> Date: Mon, 16 Oct 2017 21:15:39 +0800 In-Reply-To: <20171015200328.4830-2-ajpatter@uwaterloo.ca> (Andy Patterson's message of "Sun, 15 Oct 2017 16:03:22 -0400") Message-ID: <87r2u3kzd0.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Andy Patterson Cc: 28853@debbugs.gnu.org Andy Patterson writes: > * gnu/packages/virtualization.scm (qemu)[arguments]<#:configure-flags>: N= ew > argument. > [inputs]: Add usbredir. > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even when the= y are > set by qemu. > [inputs]: Remove usbredir. Doesn't the 'configure' script auto-detect usb redirection support when usbredir is available? > --- > gnu/packages/virtualization.scm | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualizatio= n.scm > index 5cdf6d09b..24ffc2f28 100644 > --- a/gnu/packages/virtualization.scm > +++ b/gnu/packages/virtualization.scm > @@ -4,6 +4,7 @@ > ;;; Copyright =C2=A9 2016, 2017 Efraim Flashner > ;;; Copyright =C2=A9 2016 Ricardo Wurmus > ;;; Copyright =C2=A9 2017 Alex Vong > +;;; Copyright =C2=A9 2017 Andy Patterson > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -85,7 +86,7 @@ > '(;; Running tests in parallel can occasionally lead to failures, l= ike: > ;; boot_sector_test: assertion failed (signature =3D=3D SIGNATURE= ): (0x00000000 =3D=3D 0x0000dead) > #:parallel-tests? #f > - > + #:configure-flags '("--enable-usb-redir") In that case, this and ... > #:phases > (modify-phases %standard-phases > (replace 'configure > @@ -152,6 +153,7 @@ > ("pixman" ,pixman) > ("sdl" ,sdl) > ("spice" ,spice) > + ("usbredir" ,usbredir) > ("util-linux" ,util-linux) > ;; ("vde2" ,vde2) > ("virglrenderer" ,virglrenderer) > @@ -188,14 +190,17 @@ server and embedded PowerPC, and S390 guests.") > (name "qemu-minimal") > (synopsis "Machine emulator and virtualizer (without GUI)") > (arguments > - `(#:configure-flags > - ;; Restrict to the targets supported by Guix. > - '("--target-list=3Di386-softmmu,x86_64-softmmu,mips64el-softmmu,a= rm-softmmu,aarch64-softmmu") > - ,@(package-arguments qemu))) > + (substitute-keyword-arguments (package-arguments qemu) > + ((#:configure-flags _ '(list)) > + `(list > + ,(string-append > + "--target-list=3Di386-softmmu,x86_64-softmmu,mips64el-softmm= u" > + ",arm-softmmu,aarch64-softmmu"))))) >=20=20 ... can be removed.