From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOR0s-0003QI-Kr
	for guix-patches@gnu.org; Mon, 11 Dec 2017 11:33:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOR0o-00023s-Pk
	for guix-patches@gnu.org; Mon, 11 Dec 2017 11:33:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48419)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eOR0o-00023g-Kz
	for guix-patches@gnu.org; Mon, 11 Dec 2017 11:33:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOR0o-0003ny-8a
	for guix-patches@gnu.org; Mon, 11 Dec 2017 11:33:02 -0500
Subject: [bug#29409] [PATCH 1/4] build: vm: Use netdev qemu parameter.
Resent-Message-ID: <handler.29409.B29409.151300997714613@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <1512565193-3234-1-git-send-email-m.othacehe@gmail.com>
	<1512565193-3234-2-git-send-email-m.othacehe@gmail.com>
Date: Mon, 11 Dec 2017 17:32:52 +0100
In-Reply-To: <1512565193-3234-2-git-send-email-m.othacehe@gmail.com>
	(m. othacehe's message of "Wed, 6 Dec 2017 13:59:50 +0100")
Message-ID: <87r2s1w7gr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: m.othacehe@gmail.com
Cc: 29409@debbugs.gnu.org

m.othacehe@gmail.com skribis:

> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> * gnu/build/vm.scm (load-in-linux-vm): "-net nic" option is
> deprecated, replace it with "-netdev" and "-device" options.
>
> See https://wiki.qemu.org/Documentation/Networking.
> ---
>  gnu/build/vm.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
> index 20ee127..9e868f6 100644
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -113,7 +113,8 @@ the #:references-graphs parameter of 'derivation'."
>    (unless (zero?
>             (apply system* qemu "-nographic" "-no-reboot"
>                    "-m" (number->string memory-size)
> -                  "-net" "nic,model=3Dvirtio"
> +                  "-device" "virtio-net-pci,netdev=3Dmynet"
> +                  "-netdev" "user,id=3Dmynet"

IIUC the =E2=80=9Cuser=E2=80=9D part means that it does more than just upda=
te to the new
syntax: it also enable user-level networking support (built-in DHCP
server, etc.).  Is this correct?

If so, can we leave out =E2=80=9Cuser=E2=80=9D?

Thanks,
Ludo=E2=80=99.