From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYX26-0001FR-Cf for guix-patches@gnu.org; Mon, 08 Jan 2018 08:00:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYX24-0005fC-4t for guix-patches@gnu.org; Mon, 08 Jan 2018 08:00:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:59864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYX24-0005f5-1Y for guix-patches@gnu.org; Mon, 08 Jan 2018 08:00:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eYX23-0005Wt-Pz for guix-patches@gnu.org; Mon, 08 Jan 2018 08:00:03 -0500 Subject: bug#30003: [PATCH 2/2] gnu: services: Add darkstat service. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: <20180106084523.29095-1-iyzsong@member.fsf.org> <20180106084523.29095-2-iyzsong@member.fsf.org> <87o9m5rei5.fsf@gnu.org> Date: Mon, 08 Jan 2018 20:59:26 +0800 In-Reply-To: <87o9m5rei5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 07 Jan 2018 14:21:22 +0100") Message-ID: <87r2r0ik0h.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30003-done@debbugs.gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > >> * gnu/services/monitoring.scm: New file. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. >> * doc/guix.texi (Monitoring Services): Document it. > > Nice! > > I only have minor suggestions: > >> +@subsubheading Darkstat Service >> +@cindex darkstat >> +@command{darkstat} is a packet sniffer that captures network traffic, > > I think you can remove @command since you=E2=80=99re referring to the sof= tware, > not to the command. > >> +@example >> +(service darkstat-service-type >> + (darkstat-configuration >> + (interface "eth0"))) > > This should be aligned to the right. Also perhaps s/eth0/eno1/ to match > common names. > >> +@item @code{package} (default: @code{darstat}) > ^ > Typo. > >> +@item @code{bindaddr} (default: @code{"127.0.0.1"}) > > I=E2=80=99d prefer =E2=80=9Caddress=E2=80=9D or =E2=80=9Clisten-address= =E2=80=9D or =E2=80=9Cbind-address=E2=80=9D (likewise in > the code.) > > Otherwise LGTM, thank you! Done, thanks for the review!