From: "Stefan Reichör" <stefan@xsteve.at>
To: Leo Famulari <leo@famulari.name>
Cc: 29950@debbugs.gnu.org
Subject: [bug#29950] [PATCH] gnu: Add instantmusic.
Date: Sun, 21 Jan 2018 17:23:35 +0100 [thread overview]
Message-ID: <87r2qjuqns.fsf@xsteve.at> (raw)
In-Reply-To: <20180104163342.GA2127@jasmine.lan> (Leo Famulari's message of "Thu, 4 Jan 2018 11:33:42 -0500")
Leo Famulari <leo@famulari.name> writes:
Thanks for your review. I was rather busy these days. So it took some
time until I was able to respond...
> On Tue, Jan 02, 2018 at 07:39:56PM +0100, Stefan Reichör wrote:
>> * gnu/packages/music.scm (instantmusic): New variable.
>
> Thanks for this patch Stefan! I have some comments...
>
>> + (version (string-append "0.1-" revision "." (string-take commit 9)))
>
> I noticed the latest upstream release is tagged "v1.0" rather than
> "0.1". Also, it's convenient and more maintainable to create the version
> of Git-based packages like this:
>
> (version (git-version "1.0" revision commit))
>
>> + (file-name (string-append name "-" version "-checkout"))
>
> And similarly for the file-name:
>
> (file-name (git-file-name name version))
>
> Those two procedures come from (guix git-download).
Thanks for these git related short cuts. They are rather new and not yet
widely used. But I agree that they make the description shorter and
better readable.
>> + (arguments
>> + '(#:modules ((guix build python-build-system)
>> + (guix build utils)
>> + (srfi srfi-26))
>> + #:phases (modify-phases %standard-phases
>> + (add-before 'build 'change-directory
>> + (lambda _
>> + (chdir "instantmusic-0.1")
>> + ;; Fix some read-only files that would cause a build failure
>> + (for-each (cut chmod <> #o644)
>> + (find-files "instantmusic.egg-info"
>> + "PKG-INFO|.*\\.txt"))
>> + #t)))))
>
> I guess that changing the build directory and chmod-ing those files are
> required for their own reasons, right? So they should be in separate
> build phases.
The chdir is needed to ensure that the build is started in the correct
directory. I found out that the chmod block is required in the check
phase. So I changed it that way.
> Can you send an updated patch?
* gnu/packages/music.scm (instantmusic): New variable.
---
gnu/packages/music.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index b7dc7d9..7beba4b 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2018 nee <nee.git@hidamari.blue>
+;;; Copyright © 2018 Stefan Reichör <stefan@xsteve.at>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2487,6 +2488,48 @@ websites such as Libre.fm.")
(define-public python2-pylast
(package-with-python2 python-pylast))
+(define-public instantmusic
+ (let ((commit "300891d09c703525215fa5a116b9294af1c923c8")
+ (revision "1"))
+ (package
+ (name "instantmusic")
+ (version (git-version "1.0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/yask123/Instant-Music-Downloader.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0j7qivaa04bpdz3anmgci5833dgiyfqqwq9fdrpl9m68b34gl773"))))
+ (build-system python-build-system)
+ (propagated-inputs
+ `(("python-requests" ,python-requests)
+ ("eyed3", eyed3)
+ ("python-beautifulsoup4" ,python-beautifulsoup4)
+ ("youtube-dl" ,youtube-dl)))
+ (arguments
+ '(#:modules ((guix build python-build-system)
+ (guix build utils)
+ (srfi srfi-26))
+ #:phases (modify-phases %standard-phases
+ (add-before 'build 'change-directory
+ (lambda _
+ (chdir "instantmusic-0.1") #t))
+ (add-before 'check 'fix-file-permissions
+ (lambda _
+ ;; Fix some read-only files that would cause a build failure
+ (for-each (cut chmod <> #o644)
+ (find-files "instantmusic.egg-info"
+ "PKG-INFO|.*\\.txt"))
+ #t)))))
+ (home-page "http://iyask.me/Instant-Music-Downloader/")
+ (synopsis "Command line app to download a song from youtube")
+ (description "Download a song from youtube in .mp3 format. Songs can be
+searched by artist, name or even by a part of the song text.")
+ (license license:expat))))
+
(define-public beets
(package
(name "beets")
next prev parent reply other threads:[~2018-01-21 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 18:39 [bug#29950] [PATCH] gnu: Add instantmusic Stefan Reichör
2018-01-04 16:33 ` Leo Famulari
2018-01-21 16:23 ` Stefan Reichör [this message]
2018-01-28 22:46 ` bug#29950: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2qjuqns.fsf@xsteve.at \
--to=stefan@xsteve.at \
--cc=29950@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).