Hello Ludovic,

Thank you for review!

ludo@gnu.org (Ludovic Courtès) writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 11 Jan 2018 01:14:41 +0300
>> Subject: [PATCH] gnu: Add urho3d.
>>
>> * gnu/packages/game-development.scm (urho3d): New public variable.
>
> [...]
>
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (substitute* (string-append "../build/Source/ThirdParty"
>> +                                         "/SDL/include/generated/SDL_config.h")
>
> IIUC there’s a bundled copy of SDL, right?  Can we instead build against
> our SDL?

Yes, it's a bundled copy.  We probably can, but how?  The build system
probably configured look for 'Source/ThirdParty/SDL'.  So should we make
a symbolic link like 'Source/ThirdParty/SDL' -> '/gnu/store/…-SDL'?

I'll check this later.  Maybe it will search for a system first SDL and
if not find it use their own.  Also I have a question about SDL in the
following quote.

> Ideally, to be safe from bundling, we should “rm -rf ThirdParty” in a
> snippet.  Is that possible?

Unfortunately no.  The contents of the 'Source/ThirdParty' has much more
than just SDL.  It's too much work for now, but a good TODO.

Source/ThirdParty/SDL

    AngelScript Assimp boost Box2D Bullet Civetweb Detour DetourCrowd
    DetourTileCache FreeType GLEW ik JO kNet LibCpuId LICENSES Lua
    LuaJIT LZ4 MojoShader Mustache nanodbc PugiXml rapidjson Recast SDL
    SQLite StanHull STB toluapp WebP

Actually I wonder will those libraries and the engine overall play nice
with OUR SDL library?  Should we provide a Guix version and bundled
libraries version?

>> +               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"
>> +                                " \"libpulse-simple\\.so\\.0\""))
>> +                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \""
>> +                               (assoc-ref inputs "pulseaudio")
>> +                               "/lib/libpulse-simple.so.0"
>> +                               "\"")))
>
> Please use a literal string in the ‘substitute*’ pattern (you can use
> backslashes to split it on several lines.)

OK.  Thanks for notice!

>> +    (description "Lightweight, cross-platform 2D and 3D game engine
>> +implemented in C++.  Inspired by OGRE and Horde3D.")
>
> Full sentences please!  :-)
>
>   https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

Oh, thanks!

> Could you send an updated path?