From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5Hf-00055R-Tj for guix-patches@gnu.org; Tue, 23 Jan 2018 15:35:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5Ha-0008L8-O1 for guix-patches@gnu.org; Tue, 23 Jan 2018 15:35:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee5Ha-0008Kz-Jp for guix-patches@gnu.org; Tue, 23 Jan 2018 15:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee5Ha-0008BT-8M for guix-patches@gnu.org; Tue, 23 Jan 2018 15:35:02 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> <20180122215447.GD15170@jasmine.lan> <87vafs5p79.fsf@cbaines.net> <20180123202935.GD6750@jasmine.lan> From: Christopher Baines In-reply-to: <20180123202935.GD6750@jasmine.lan> Date: Tue, 23 Jan 2018 20:34:23 +0000 Message-ID: <87r2qg5n74.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30214@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Tue, Jan 23, 2018 at 07:51:06PM +0000, Christopher Baines wrote: >> Leo Famulari writes: >> > On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: >> >> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New vari= able. >> > >> >> + (add-after 'unpack 'rename-archive >> >> + (lambda _ >> >> + (rename-file >> >> + ,(string-append "src/github.com/jessevdk/go-flags-" ve= rsion) >> >> + "src/github.com/jessevdk/go-flags") >> >> + #t))))) >> > >> > Should the go-build-system try to handle this automatically? >>=20 >> I believe this might be connected with what is in the source >> tarball. Without this stage, the go-flags directory is called >> go-flags-1.3.0, and this causes the build to fail [2]. > > Oh right, Go expects you to use Git checkouts instead of release > tarballs. I bet it works if you do that. That kind of tarball is > automatically created by GitHub per tag, and can't be disabled. > >> I'm not sure about the wider context, but it would be good to handle >> this automatically. > > So, I think the build system doesn't need to handle this case. Ok, would it be more appropriate to use a git checkout, rather than a tar archive for these packages then? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpnnE9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcOwQ//dNN50WRvgalU2hfVt1yCJWdbdZcQsSv75I1PyORkdHqGXE6dz8CeYevl N7nMap4NMq1ML2V3UlgRGUxf7YPhuju1oqSPMn2/ai13byZKgMc+D5mzrvfchwmo uuf30xTlsEujaE9dEjJu98w0FaABSjKZbmVe9R8oW3IhitvmNA2mPmffrmXhpdFB XLCg1Fc1LkFgbRWta0tZkMnA1ma2pm6jdoDHg1iFndxKxrh/PyKkBZtdbJ9lkJT0 af7v9DW0RKg5GoUqEs1Y982CshIAnNJACsS8ZtNGgwMBfoDpi1GpOtW15y8L+vWq /psgD1i0ilrm/0bB1d8HdBmQpjl5yJsmOFHDMYdgII099UKU/OS5VGPMy8kb5Mea IMewzkMKjsN0yPIH5VNbelybAdpb5aOoVYF0FS1Jao8KKRKb6m4aGvW68o5Kg+4Q 5HFCn8/fPsj6IwvU3u/Cp2ayBDBLjPrdV7bDI7YVwZ9tcsrrd90ZkHJaN54f2ux4 D+NiWdAgGD7UlZul7aEwCI95uVjj8gkzUHjoaDDEFc81BqQqqZ5+LzpBeD4b4GR3 a0HO0uDoZjKf0sQ4+3zWW2oBEQ+pShU4BwKG6j6/jn4S4Ragybf2WZR77NcSuZIH KsG0MWwsohqUqnc7GZJI3K1J2a6oG5rNucOtD+YAEvc/k36MJGM= =ycQX -----END PGP SIGNATURE----- --=-=-=--