From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57181)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqbD5-00020G-Dc
	for guix-patches@gnu.org; Tue, 27 Feb 2018 04:06:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqbD0-0005cT-FI
	for guix-patches@gnu.org; Tue, 27 Feb 2018 04:06:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54614)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eqbD0-0005cC-C6
	for guix-patches@gnu.org; Tue, 27 Feb 2018 04:06:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqbCz-0008Te-WF
	for guix-patches@gnu.org; Tue, 27 Feb 2018 04:06:02 -0500
Subject: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Resent-Message-ID: <handler.30601.D30601.151972232832539@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180225035438.24171-1-mbakke@fastmail.com>
	<87fu5nvdxe.fsf@gnu.org> <87sh9nv8s4.fsf@fastmail.com>
	<87po4rv7sw.fsf@fastmail.com>
Date: Tue, 27 Feb 2018 10:05:22 +0100
In-Reply-To: <87po4rv7sw.fsf@fastmail.com> (Marius Bakke's message of "Mon, 26
	Feb 2018 21:02:07 +0100")
Message-ID: <87r2p66bvx.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30601-done@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>>
>>> Hi!
>>>
>>> Marius Bakke <mbakke@fastmail.com> skribis:
>>>
>>>> * gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.=
  Adjust
>>>> CHECK-PHASE accordingly.
>>>> ---
>>>>  gnu/packages/ninja.scm | 20 +++++++++++++++-----
>>>>  1 file changed, 15 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
>>>> index adb236484..cff2ac38b 100644
>>>> --- a/gnu/packages/ninja.scm
>>>> +++ b/gnu/packages/ninja.scm
>>>> @@ -42,7 +42,15 @@
>>>>      (build-system gnu-build-system)
>>>>      (native-inputs `(("python" ,python-2)))
>>>>      (arguments
>>>> -     '(#:phases
>>>> +     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like thi=
s:
>>>> +     ;;   *** Failure in src/subprocess_test.cc:241
>>>> +     ;;   ExitSuccess =3D=3D procs[i]->Finish()
>>>> +     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
>>>> +     ;; Disable for now.
>>>
>>> Sounds reasonable.  Could you also report it upstream?  :-)
>>
>> Actually, now that I'm more awake, I found the problem.  On most
>> machines this test is skipped because it requires 1025 open files.
>> However, on Hydras armhf machines, this limit is apparently higher.
>>
>> The problem is that the test calls out to /bin/echo.  I was able to
>> reproduce it on x86_64 simply by raising the softlimit to 4096.
>>
>> So, I pushed a one-line fix as d0de4c40e24ee52e4382ee2ac82088932ab49099.
>
> Derp.  Apparently I wasn't awake enough and managed to patch the wrong
> file when making the commit.  The followup in
> 6d796220c417a34100c282a7fa1f9afb6ac00339 fixes it, sorry for the noise.

Heh, thank you!

Ludo=E2=80=99.