From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evOhG-0003Xh-OG for guix-patches@gnu.org; Mon, 12 Mar 2018 10:45:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evOhC-0005WY-QX for guix-patches@gnu.org; Mon, 12 Mar 2018 10:45:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evOhC-0005WP-MD for guix-patches@gnu.org; Mon, 12 Mar 2018 10:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evOhC-0001xa-G0 for guix-patches@gnu.org; Mon, 12 Mar 2018 10:45:02 -0400 Subject: [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87k1uhpf5p.fsf@gnu.org> References: <20180309180914.22752-1-mbakke@fastmail.com> <20180309181108.22888-1-mbakke@fastmail.com> <87vae2tfxy.fsf@gnu.org> <876061jw9o.fsf@fastmail.com> <87k1uhpf5p.fsf@gnu.org> Date: Mon, 12 Mar 2018 15:44:24 +0100 Message-ID: <87r2opicaf.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30761@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Hello! >>> >>> Marius Bakke skribis: >>> >>>> * gnu/packages/build-tools.scm (meson)[arguments]: Delete WRAP-PHASE. >>>> --- >>>> gnu/packages/build-tools.scm | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.s= cm >>>> index 2abb44fdb..1ebccca43 100644 >>>> --- a/gnu/packages/build-tools.scm >>>> +++ b/gnu/packages/build-tools.scm >>>> @@ -81,6 +81,11 @@ makes a few sacrifices to acquire fast full and inc= remental build times.") >>>> (base32 >>>> "06r8limj38mv884s5riiz6lpzw37cvhbf9jd0smzcbi7fwmv3yah= ")))) >>>> (build-system python-build-system) >>>> + (arguments >>>> + `(#:phases (modify-phases %standard-phases >>>> + ;; Meson runs itself through the Python interpreter= , so >>>> + ;; we cannot use the shell wrapper. >>>> + (delete 'wrap)))) >>> >>> I=E2=80=99m not sure what this means. The =E2=80=98wrap=E2=80=99 phase= is precisely for things >>> with #!/=E2=80=A6/python, right? >>> >>> What problem does it solve? >> >> The problem is that at some point after 0.42 (the current >> meson-for-build), Meson does the equivalent of `python $(which meson)` >> at runtime. Which ends up tripping over the shell wrapper. >> >> I don't remember exactly where I saw the problem, it could have been >> with "mesontest" which also resides in "meson/bin". The only downside >> to deleting the wrapper is that you cannot call meson directly from the >> store; it works fine as long as PYTHONPATH is set (e.g. in a profile). >> >> I'll try to clarify the comment. > > Yes, that=E2=80=99s a good idea. :-) > > It does mean that people installing meson in their profile will get > something missing-python-module errors, right? Meson actually propagates Python, which will set up PYTHONPATH. So in a profile or environment it works just fine. The only problem is when trying to invoke /gnu/store/...meson-0.45/bin/meson directly. > Should we do the wrapping differently? ISTR a discussion about a language-aware wrapper, which would solve this. Then we could wrap it with PATH and PYTHONPATH and get rid of Python propagation. But for now I think we're good :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqmkkgACgkQoqBt8qM6 VPq4FwgA0ionCBQc3eImyddysjImu13CYBsvK+P/+F1LHFPH+7FeqZhmMD7iehO6 jzDLtSwL4jLkEdDEAF02zFO20BdIch8rp7oeR4XOeSKSkqhhvvaDZbxEbpHJsttv VQyZFwzglwfu7FWdAJBatH3DMIYfELP2Xqw1vHw6v1hgBj6tAj/LL4zhHb41alji SGuflJaZF3//FlIyBiBOf/edICGhD35o0dA3nRMOnTR2bn57FvCpbNz4zkW0vM6+ vZmiOF5TurvMyLNARy+hDMG8JSF+EyWXNZhMtj2OP5FL9TnquEbzpfgETqjWzuIx 5QJ1er+j+VUbjBVHeX6+TBFeohwk4w== =46qz -----END PGP SIGNATURE----- --=-=-=--