unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31447@debbugs.gnu.org, Mark H Weaver <mhw@netris.org>
Subject: [bug#31447] [PATCH] linux-libre: Add aarch64-linux.
Date: Sun, 20 May 2018 15:26:16 -0700	[thread overview]
Message-ID: <87r2m6rmk7.fsf@aikidev.net> (raw)
In-Reply-To: <87zi0u565h.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

On 2018-05-20, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@debian.org> skribis:
>> I did try to restrict dtb installation based on architecture (only arm,
>> arm64 and mips linux architectures currently implement the dtbs_install
>> Makefile target), which would seem a little cleaner to me. My attempt
>> was essentially:
>>
>>   (if (string=? (getenv "ARCH") (or "arm" "arm64" "mips"))
>>     (invoke "make" "dtbs_install" ... )
>>   )
>
> You could do:
>
>  (when (member (getenv "ARCH") '("arm" "arm64" "mips"))
>    …)

Thanks for the suggestion.


> But I think what you did is even nicer (no need to hardwire the list of
> architectures.)

My only concern was the risk of an architecture which generates .dtb
files, but for some reason doesn't have the dtbs_install target.  Maybe
that's too hypothetical at this point, and it can be dealt with if it
ever comes up. :)


>> From 4e5ea2e07282b3c3125fc1922e729085a2e2706f Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@debian.org>
>> Date: Sat, 19 May 2018 21:08:41 +0000
>> Subject: [PATCH 2/2] gnu: linux-libre: Use "make dtbs_install" to install
>>  device tree files.
>>
>> * gnu/packages/linux.scm (make-linux-libre):
>>   Use "make dtbs_install" to install device tree files.
>
> I adjusted the indentation and committed.  Thank you!

Great!


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-05-20 22:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  3:40 [bug#31447] [PATCH] linux-libre: Add aarch64-linux Vagrant Cascadian
2018-05-17  8:53 ` Ludovic Courtès
2018-05-17 18:44   ` Mark H Weaver
2018-05-17 22:05     ` Vagrant Cascadian
2018-05-18  4:38       ` Mark H Weaver
2018-05-18 22:31       ` Vagrant Cascadian
2018-05-19 23:33         ` Vagrant Cascadian
2018-05-20 22:11           ` Ludovic Courtès
2018-05-20 22:26             ` Vagrant Cascadian [this message]
2018-05-20 22:12         ` bug#31447: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2m6rmk7.fsf@aikidev.net \
    --to=vagrant@debian.org \
    --cc=31447@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).