unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 32321@debbugs.gnu.org
Subject: [bug#32321] [PATCH] gnu: Add povray.
Date: Thu, 02 Aug 2018 14:05:37 -0400	[thread overview]
Message-ID: <87r2jgd4pa.fsf@posteo.net> (raw)
In-Reply-To: <20180802152501.GF13776@macbook41> (Efraim Flashner's message of "Thu, 2 Aug 2018 18:25:01 +0300")

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, Jul 30, 2018 at 10:36:00PM -0400, Kei Kebreau wrote:
>
>> +    (version "3.7.0.8")
>> +    (source (origin
>> +              (method url-fetch)
>> + (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
>> +                                  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>
> Don't use the unstable tarball, download it using git-fetch.

If I'm not misunderstanding POV-Ray's version numbering scheme, this is
a source code maintainance release with no changes in functionality.
See "https://github.com/POV-Ray/povray/releases/tag/v3.7.0.8".

>
>> +              (sha256
>> +               (base32
>> +                "1r2xaym48gmnh577h41ccs3i7dpg7aw0x838y4m4bz3j56yixlak"))
> <snip>
>> +             (string-append "--with-boost-libdir="
>> +                            (assoc-ref %build-inputs "boost") "/lib")
>> +             "CXXFLAGS=-std=c++11"
>> +             "--disable-optimiz-arch")
>
> I have to ask, is 'optimiz' spelled correctly?

Indeed it is. See "https://github.com/POV-Ray/povray/search?q=optimiz" (or
just grep in "unix/install.txt" and "unix/configure.ac" in the source
distribution).

>
>> +       #:phases
> <snip>
>
> It built without any problems for me on aarch64

Excellent, and thanks for reviewing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-08-02 18:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 20:53 [bug#32321] [PATCH] gnu: Add povray Kei Kebreau
2018-07-31  2:36 ` Kei Kebreau
2018-08-02 15:25   ` Efraim Flashner
2018-08-02 18:05     ` Kei Kebreau [this message]
2018-08-03  1:52       ` Kei Kebreau
2018-08-05  4:32         ` bug#32321: " Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2jgd4pa.fsf@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=32321@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).