From: ludo@gnu.org (Ludovic Courtès)
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: Mark Meyer <mark@ofosos.org>, 30771@debbugs.gnu.org
Subject: [bug#30771] [PATCH] gnu: Add kdenlive.
Date: Sat, 29 Sep 2018 23:52:39 +0200 [thread overview]
Message-ID: <87r2hcvumw.fsf@gnu.org> (raw)
In-Reply-To: <20180922200835.3554-1-boskovits@gmail.com> ("Gábor Boskovits"'s message of "Sat, 22 Sep 2018 22:08:35 +0200")
Hello Gábor!
Gábor Boskovits <boskovits@gmail.com> skribis:
> From: Mark Meyer <mark@ofosos.org>
>
> * gnu/packages/kde.scm (kdenlive): New variable.
>
> Co-authored-by: Gábor Boskovits <boskovits@gmail.com>
> Signed-off-by: Gábor Boskovits <boskovits@gmail.com>
[...]
> + (add-after 'install 'wrap-executable
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (qtquickcontrols (assoc-ref inputs "qtquickcontrols"))
> + (qtbase (assoc-ref inputs "qtbase"))
> + (qtdeclarative (assoc-ref inputs "qtdeclarative"))
> + (frei0r (assoc-ref inputs "frei0r-plugins"))
> + (qml "/lib/qt5/qml"))
> + (wrap-program (string-append out "/bin/kdenlive")
> + `("QT_PLUGIN_PATH" ":" prefix
> + ,(map (lambda (label)
> + (string-append (assoc-ref inputs label)
> + "/lib/qt5/plugins/"))
> + '("qtbase", "qtsvg")))
> + `("FREI0R_PATH" ":" =
> + (,(string-append frei0r "/lib/frei0r-1/")))
> + `("QT_QPA_PLATFORM_PLUGIN_PATH" ":" =
> + (,(string-append qtbase "/lib/qt5/plugins/platforms")))
> + `("QML2_IMPORT_PATH" ":" prefix
> + (,(string-append qtquickcontrols qml)
> + ,(string-append qtdeclarative qml))))))))))
Please explicitly return #t.
Apart from this very minor issue, it LGTM. Thank you!
Ludo’.
next prev parent reply other threads:[~2018-09-29 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 21:12 [bug#30771] Add kdenlive Mark Meyer
2018-03-11 21:17 ` [bug#30771] Quick update for lint Mark Meyer
2018-03-11 21:25 ` [bug#30771] Change formatting Mark Meyer
2018-09-22 20:08 ` [bug#30771] [PATCH] gnu: Add kdenlive Gábor Boskovits
2018-09-29 21:52 ` Ludovic Courtès [this message]
2018-10-01 9:20 ` [bug#30771] " Nils Gillmann
2019-02-13 0:04 ` bug#30771: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2hcvumw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30771@debbugs.gnu.org \
--cc=boskovits@gmail.com \
--cc=mark@ofosos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).