From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXjhT-00060J-27 for guix-patches@gnu.org; Fri, 14 Dec 2018 04:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXjhS-0001uS-4N for guix-patches@gnu.org; Fri, 14 Dec 2018 04:24:03 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXjhS-0001uF-0s for guix-patches@gnu.org; Fri, 14 Dec 2018 04:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXjhR-0006tR-S6 for guix-patches@gnu.org; Fri, 14 Dec 2018 04:24:01 -0500 Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-Message-ID: References: <871s6l9h54.fsf@gnu.org> From: Pierre Neidhardt In-reply-to: <871s6l9h54.fsf@gnu.org> Date: Fri, 14 Dec 2018 10:23:41 +0100 Message-ID: <87r2ekea1u.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Tim Gesthuizen , 33598@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Tim! Thanks for working on this. I'm just a little confused about the intention, so I have a few questions. The current package re-uses Clang source and packages clang-format.el / clang-rename.el only. In your implementation, you've essentially moved the 'configure phase to a snippet. As I understand it, this does not change anything. What is your reason for doing this? You are also deleting all non-required files. Which saves some space in /t= mp indeed, but this won't change anything to the store or the resulting substitutes, right? I don't mind this change, I just want to be clear about what we are trying to achieve here :) Last, the factorization into package-from-clang-elisp-file: this is a good = idea, and I would make it even more generic. Simply rename your function package-elisp-from-package (or something like that) and make "clang" a parameter. Then we can use this function in other packages like emacs-agda2-mode. Am I making sense? What do you think? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwTdp0ACgkQm9z0l6S7 zH9TjQf+IqBdKyOSMm+ZjPnLXVZfyuP6WMq5eXaPYkhuPBclcvnbc175a3FYrGGR E+Qsecgh6vUE+0i+FJKQl+LNOV6BZWbZEA0VBfrJIWKOL2U/J456PBuSienKUJtS AsVSzVGXE1hidEziO5UrrP7w+xXBoaUosKkblV/ptqLwqMfenyf2SWyrtHieQbK7 3NM2Q5xahLDBu2+PUNtxEwJyjmM9g2h718xx3nmWFaw1dQqhGpaq7Bu0l8H/4M8h cxK9x3z6N6CO9Qu5PLVn6gi0O3a/uCK1Si8SvZfGk/5AIHNSsh9YTTK3dhfJ+Vug bxss6YVI1g1XDlTsMelQLZEzTeZ7pQ== =HpwN -----END PGP SIGNATURE----- --=-=-=--