unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 34571@debbugs.gnu.org
Subject: [bug#34571] [PATCH] Add micropython
Date: Tue, 19 Feb 2019 14:02:36 +0100	[thread overview]
Message-ID: <87r2c4ue1f.fsf@elephly.net> (raw)
In-Reply-To: <20190219092216.GA32103@macbook41>


Efraim Flashner <efraim@flashner.co.il> writes:

> I was looking around to see if there was an alternate perl
> implementation and I ended up packaging micropython. I have no
> preference between it being in python.scm or embedded.scm

“python.scm” seems fine.

> +         (add-before 'build 'preprare-build

Typo: preprare –> prepare

> +           (lambda _
> +             (chdir "ports/unix")
> +             ;; see: https://github.com/micropython/micropython/pull/4246
> +             (substitute* "Makefile"
> +               (("-Os") "-Os -ffp-contract=off"))
> +             #t))
> +         (delete 'configure)) ; no configure
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +                          "V=1")
> +       #:test-target "test"))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("python" ,python-minimal-wrapper)))

Oh, this Python needs Python…?  I think you should be using
python-wrapper here as the python-minimal variants are merely supposed
to be used for breaking a cycle in the build of Python itself.

--
Ricardo

  parent reply	other threads:[~2019-02-19 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19  9:22 [bug#34571] [PATCH] Add micropython Efraim Flashner
2019-02-19  9:46 ` Danny Milosavljevic
2019-02-19 10:10   ` Efraim Flashner
2019-02-19 10:37     ` Efraim Flashner
2019-02-19 13:02 ` Ricardo Wurmus [this message]
2019-02-20  7:10 ` bug#34571: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2c4ue1f.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34571@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).