From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBmB2-0007mL-R3 for guix-patches@gnu.org; Wed, 03 Apr 2019 16:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBmB1-0008OM-QL for guix-patches@gnu.org; Wed, 03 Apr 2019 16:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBmB1-0008Ji-00 for guix-patches@gnu.org; Wed, 03 Apr 2019 16:08:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBmAz-0008Ku-Is for guix-patches@gnu.org; Wed, 03 Apr 2019 16:08:02 -0400 Subject: [bug#35127] [PATCH] Add meritous. Resent-Message-ID: References: <87ftqzhtvz.fsf@nicolasgoaziou.fr> From: Ricardo Wurmus In-reply-to: <87ftqzhtvz.fsf@nicolasgoaziou.fr> Date: Wed, 03 Apr 2019 22:07:21 +0200 Message-ID: <87r2aiyhs6.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 35127@debbugs.gnu.org Hi Nicolas, > + (add-after 'unpack 'fix-sdl-path > + ;; XXX: For some reason, `sdl-config' reports stand-alone SDL > + ;; directory, not SDL-union provided as an input to the packa= ge. > + ;; We force the latter with "--prefix=3D" option. > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "Makefile" > + (("sdl-config" command) > + (string-append command " --prefix=3D" (assoc-ref inputs = "sdl")))) > + #t)) Hmm, weird. Do you know why this happens? Is this something we can fix in sdl-union? > + (add-after 'unpack 'fix > + ;; XXX: Songs are removed due to licensing issues. However, = the > + ;; game tries to load them, and, since it cannot find them, > + ;; crashes. Users cannot add them back, the store being read= -only, > + ;; so we turn off background music altogether. Oh :( Where are the songs removed? Should they be removed in a snippet? > + (lambda _ > + (substitute* "src/audio.c" > + (("PlayBackgroundMusic\\(new_track\\);" all) > + (string-append "// " all)))))))) Please end with #T. > + (native-inputs > + `(("intltool" ,intltool))) > + (inputs > + `(("sdl" ,(sdl-union (list sdl sdl-image sdl-mixer))) > + ("zlib" ,zlib))) > + ;; Original home page has stalled. I don=E2=80=99t think =E2=80=9Cstalled=E2=80=9D is the right term. I think= you can remove this comment. The gitlab page is fine as a home page. > + (description "Far below the surface of the planet is a secret. A pl= ace of > +limitless power. How about =E2=80=9Ca secret place of limitless power=E2=80=9D? (=E2=80=9Ci= s a secret=E2=80=9D sounds odd to me.) > +Meritous is a action-adventure game with simple controls but a challenge= to > +find a balance of power verses recovery time during real-time > battles. Should be =E2=80=9Cversus=E2=80=9D. -- Ricardo