From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:41010)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0cZ-0003JP-9q
	for guix-patches@gnu.org; Tue, 07 May 2019 09:59:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0cY-0004E6-7Z
	for guix-patches@gnu.org; Tue, 07 May 2019 09:59:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45722)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hO0cY-0004Dv-4H
	for guix-patches@gnu.org; Tue, 07 May 2019 09:59:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO0cY-00006u-2C
	for guix-patches@gnu.org; Tue, 07 May 2019 09:59:02 -0400
Subject: [bug#35544] [PATCH] services: dovecot: Rename auth-verbose-passwords?.
Resent-Message-ID: <handler.35544.B35544.1557237539413@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190503091039.12424-1-mail@cbaines.net>
Date: Tue, 07 May 2019 15:58:50 +0200
In-Reply-To: <20190503091039.12424-1-mail@cbaines.net> (Christopher Baines's
	message of "Fri, 3 May 2019 10:10:39 +0100")
Message-ID: <87r29a5pt1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35544@debbugs.gnu.org

Hello!

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/services/mail.scm (dovecot-configuration)[auth-verbose-passwords?]:
> Rename to auth-verbose-passwords, and change the type to a string, as this
> parameter can take one of three string values.
> * doc/guix.texi (Dovecot service): Update the corresponding documentation.

I don=E2=80=99t use the Dovecot service but this LGTM.

The question is whether it=E2=80=99s OK to break the API.  I=E2=80=99d say =
that with
proper documentation it probably is.  Thoughts?

Longer-term we=E2=80=99ll need a way to gracefully handle deprecation for t=
his
kind of change, probably at the level of the =E2=80=98define-record-type*=
=E2=80=99
kitchen sink.

Thanks,
Ludo=E2=80=99.