unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35880@debbugs.gnu.org
Subject: [bug#35880] [PATCH 7/7] lzlib: 'lzread!' never returns more than it was asked for.
Date: Sun, 26 May 2019 22:57:51 +0200	[thread overview]
Message-ID: <87r28llyr4.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87zhn9kn3p.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Pierre Neidhardt <mail@ambrevar.xyz> skribis:
>
>>> Fixes a bug whereby 'lzread!' could return more than COUNT.
>>
>> Hmm... But why is this a bug?
>
> Because then the ‘read!’ method of the custom binary input port could
> return more than ‘count’, which is understandably not permitted.

That's the part where I'm a bit confused because we deal with compressed
data here.

So when we say "(read count)", does COUNT refer to the compressed or
uncompressed data?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-05-26 20:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 13:31 [bug#35880] [PATCH 0/7] Lzip support for 'guix publish' and 'guix substitute' Ludovic Courtès
2019-05-24 13:42 ` [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed' Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 2/7] utils: Test 'compressed-port' and 'decompressed-port' for both gzip and xz Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 3/7] utils: Support compression and decompression with lzip Ludovic Courtès
2019-05-25 17:27     ` Pierre Neidhardt
2019-05-26 19:52       ` Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 4/7] publish: Add support for lzip Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 5/7] self: Add dependency on lzlib Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 6/7] gnu: guix: " Ludovic Courtès
2019-05-24 13:42   ` [bug#35880] [PATCH 7/7] lzlib: 'lzread!' never returns more than it was asked for Ludovic Courtès
2019-05-25 17:31     ` Pierre Neidhardt
2019-05-26 19:54       ` Ludovic Courtès
2019-05-26 20:57         ` Pierre Neidhardt [this message]
2019-05-26 21:28           ` Ludovic Courtès
2019-05-27  7:00             ` Pierre Neidhardt
2019-05-27 10:00               ` Ludovic Courtès
2019-05-25 17:24   ` [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed' Pierre Neidhardt
2019-05-26 19:51     ` Ludovic Courtès
2019-05-27 15:45       ` Ludovic Courtès
2019-05-27 16:24         ` Pierre Neidhardt
2019-05-27 20:53           ` bug#35880: " Ludovic Courtès
2019-05-27 21:12             ` [bug#35880] " Pierre Neidhardt
2019-05-28  7:52               ` Ludovic Courtès
2019-05-28  8:46                 ` Pierre Neidhardt
2019-05-28 13:47                   ` Ludovic Courtès
2019-05-29 14:57                     ` Pierre Neidhardt
2019-05-31 20:54                       ` Ludovic Courtès
2019-06-01  6:02                         ` Pierre Neidhardt
2019-06-01  9:41                           ` Ludovic Courtès
2019-06-01  9:58                             ` Pierre Neidhardt
2019-06-01 12:21                               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r28llyr4.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=35880@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).