From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:56242)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hV0cf-0001VL-Ka
	for guix-patches@gnu.org; Sun, 26 May 2019 17:24:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hV0cc-0008GO-K8
	for guix-patches@gnu.org; Sun, 26 May 2019 17:24:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:38407)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hV0cc-0008GJ-HZ
	for guix-patches@gnu.org; Sun, 26 May 2019 17:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hV0cc-0005pp-Ca
	for guix-patches@gnu.org; Sun, 26 May 2019 17:24:02 -0400
Subject: bug#35812: [PATCH] fix hackage cabal tests
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35812.D35812.155890582022393.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <A3819F46-CC09-47A7-A1C6-41544086132F@vllmrt.net>
	<874l5n2799.fsf@gnu.org>
	<616C2CBF-8171-401C-9515-5679A5E01823@vllmrt.net>
Date: Sun, 26 May 2019 23:23:27 +0200
In-Reply-To: <616C2CBF-8171-401C-9515-5679A5E01823@vllmrt.net> (Robert
	Vollmert's message of "Tue, 21 May 2019 17:10:51 +0200")
Message-ID: <87r28kkj00.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35812-done@debbugs.gnu.org

Hi,

Robert Vollmert <rob@vllmrt.net> skribis:

>> On 21. May 2019, at 16:48, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
>> Robert Vollmert <rob@vllmrt.net> skribis:
>>=20
>>> Hackage cabal tests didn=E2=80=99t run independently due to memoization,
>>> and test-cabal-6 was failing.
>>=20
>> I don=E2=80=99t think memoization can get in the way here: the argument =
list is
>> used as a key in the memoization hash table.  Thus, if you pass
>> different arguments, you get a cache miss and call the underlying
>> procedure.
>>=20
>> Or am I missing something?
>
> I agree that memoization of a pure function shouldn=E2=80=99t have such e=
ffects,
> but my (limited) understanding is that hackage->guix-packages would
> cache import results by package name on the assumption that cabal
> files for the same package name don=E2=80=99t change between calls.

Oh, got it.

I pushed a variant of the patch as commit
ad7466aafd7f166d0b6be5eb32dda1d3ee8a6445.

Thanks!

Ludo=E2=80=99.