unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35812-done@debbugs.gnu.org
Subject: bug#35812: [PATCH] fix hackage cabal tests
Date: Sun, 26 May 2019 23:23:27 +0200	[thread overview]
Message-ID: <87r28kkj00.fsf@gnu.org> (raw)
In-Reply-To: <616C2CBF-8171-401C-9515-5679A5E01823@vllmrt.net> (Robert Vollmert's message of "Tue, 21 May 2019 17:10:51 +0200")

Hi,

Robert Vollmert <rob@vllmrt.net> skribis:

>> On 21. May 2019, at 16:48, Ludovic Courtès <ludo@gnu.org> wrote:
>> Robert Vollmert <rob@vllmrt.net> skribis:
>> 
>>> Hackage cabal tests didn’t run independently due to memoization,
>>> and test-cabal-6 was failing.
>> 
>> I don’t think memoization can get in the way here: the argument list is
>> used as a key in the memoization hash table.  Thus, if you pass
>> different arguments, you get a cache miss and call the underlying
>> procedure.
>> 
>> Or am I missing something?
>
> I agree that memoization of a pure function shouldn’t have such effects,
> but my (limited) understanding is that hackage->guix-packages would
> cache import results by package name on the assumption that cabal
> files for the same package name don’t change between calls.

Oh, got it.

I pushed a variant of the patch as commit
ad7466aafd7f166d0b6be5eb32dda1d3ee8a6445.

Thanks!

Ludo’.

      reply	other threads:[~2019-05-26 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 19:06 [bug#35812] [PATCH] fix hackage cabal tests Robert Vollmert
2019-05-21 14:48 ` Ludovic Courtès
2019-05-21 15:10   ` Robert Vollmert
2019-05-26 21:23     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r28kkj00.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35812-done@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).