* [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services.
@ 2019-07-31 18:13 Jakob L. Kreuze
2019-08-02 9:21 ` bug#36880: " Danny Milosavljevic
0 siblings, 1 reply; 3+ messages in thread
From: Jakob L. Kreuze @ 2019-07-31 18:13 UTC (permalink / raw)
To: 36880
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
Fixes <https://bugs.gnu.org/36878>.
Reported by Robert Vollmert <rob@vllmrt.net>.
* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
guix/scripts/system/reconfigure.scm | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@ services as defined by OS."
target-services)
(map live-service-canonical-name
live-services)))
- (service-files
- (map shepherd-service-file
- (filter (lambda (service)
- (memq (shepherd-service-canonical-name service)
- to-start))
- target-services))))
+ (service-files (map shepherd-service-file target-services)))
(eval #~(primitive-load #$(upgrade-services-program service-files
to-start
to-unload
--
2.22.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#36880: [PATCH] reconfigure: Reload all shepherd files when upgrading services.
2019-07-31 18:13 [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services Jakob L. Kreuze
@ 2019-08-02 9:21 ` Danny Milosavljevic
2019-08-02 15:08 ` [bug#36880] " Jakob L. Kreuze
0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2019-08-02 9:21 UTC (permalink / raw)
To: Jakob L. Kreuze; +Cc: 36880-done
[-- Attachment #1: Type: text/plain, Size: 106 bytes --]
I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.
Thanks!
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services.
2019-08-02 9:21 ` bug#36880: " Danny Milosavljevic
@ 2019-08-02 15:08 ` Jakob L. Kreuze
0 siblings, 0 replies; 3+ messages in thread
From: Jakob L. Kreuze @ 2019-08-02 15:08 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 36880-done
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.
>
> Thanks!
Excellent; thank you, Danny!
Regards,
Jakob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-02 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-31 18:13 [bug#36880] [PATCH] reconfigure: Reload all shepherd files when upgrading services Jakob L. Kreuze
2019-08-02 9:21 ` bug#36880: " Danny Milosavljevic
2019-08-02 15:08 ` [bug#36880] " Jakob L. Kreuze
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).