[bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants.

[Jan Nieuwenhuizen <janneke@gnu.org>]

Carl Dong writes:

Hi Carl,

> Thank you for your thorough review, definitely a lot to learn for me
> still :-)

You're welcome -- however my patches are no better than yours, I was
very happy with its state.

>> As a general remark, in GNU we avoid the use the prefix `win' when we
>> mean Microsoft Windows.  We either use `windows' in full, or `w' (or
>> w32).  (https://www.gnu.org/prep/standards/html_node/Trademarks.html).
>>
>> So, what about using `-windows-pthreads' and `with-windows-pthreads',
>> throughout?
>
> Actually, the library itself is called `winpthreads` according to
> http://mingw-w64.org/ and as seen in the codebase here:
> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-libraries/winpthreads/,
> is that okay?

Ah, I see.  That is unfortunate.  We would need a maintainer to decide
then, I'm CC'ing Ludo'.  Personally I would still prefer
`windows-pthreads' or `wpthreads'.

> I believe I've addressed the rest of the concerns in the patch below, thanks
> again!

Certainly, other than that, LGTM!

Thanks a lot for your patch.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com