From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRJQ3-0002nw-Lt for guix-patches@gnu.org; Sun, 03 Nov 2019 12:12:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRJQ2-00016W-Js for guix-patches@gnu.org; Sun, 03 Nov 2019 12:12:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54451) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRJQ2-00016R-Ge for guix-patches@gnu.org; Sun, 03 Nov 2019 12:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iRJQ2-0004dV-7X for guix-patches@gnu.org; Sun, 03 Nov 2019 12:12:02 -0500 Subject: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87tv7nlx1q.fsf@yamatai> References: <20191019184837.21457-1-glv@posteo.net> <87tv7oo5xa.fsf@devup.no> <87tv7nlx1q.fsf@yamatai> Date: Sun, 03 Nov 2019 18:11:50 +0100 Message-ID: <87r22oopex.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Guillaume Le Vaillant Cc: 37825@debbugs.gnu.org --=-=-= Content-Type: text/plain Guillaume Le Vaillant writes: > Marius Bakke skribis: > >> Guillaume Le Vaillant writes: >> >>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. >>> [source]: Fix uri. >>> [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). >>> [arguments]: Add 'fix-tests' phase. >> >> [...] >> >>> + (arguments >>> + (substitute-keyword-arguments (package-arguments bitcoin-core) >>> + ((#:phases phases) >>> + `(modify-phases ,phases >>> + (add-after 'unpack 'fix-tests >>> + ;; Disable 'check-devtools' test which tries to run a >>> + ;; python script that doesn't exist. >>> + (lambda _ >>> + (substitute* "Makefile.in" >>> + (("^check-local: check-devtools") >>> + "check-local:")) >>> + #t)))))) >> >> Do you know why this script is not distributed? Should we provide it, >> or was it a packaging mistake upstream? >> >> In any case I pushed this patch in >> 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you! > > I'm not sure if it's a packaging mistake or a makefile mistake (if these > tests are not supposed to be run on a release version). They are tests > to check that some development tools work correctly (e.g. tools to > generate a header file which is included in the release tarball, to > update the copyright years in the headers, etc). I see, thanks for the explanation. Perhaps we are simply using the wrong Makefile target? By default gnu-build-system runs 'make check' in the 'check' phase: some packages use 'make test' or 'make ci' instead. Something to look out for in the next version. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2/ClcACgkQoqBt8qM6 VPqtgwf+O/bNWF7RWcvTbZWX7XBbC9njVW+JcMv5fcqkoLD4GwTSSIdgvmCBYdQr tYUTz3EY2W4C0EjosTD79kUe0Wn+13sXvLzYfttbIimOlNxRwROYUbBpKQlHwh7O dOBI1F5YB9TjeFZmLsrtRCGXKX81bYMrjqTBtlq9q0oV3+cObTpN4lNUb0b6YSLZ yaSNVuJUd9nYTPyPAGy09GlYryivvdyPEC6IZt76M6H4mylS03ZPj9pXCtZI3cvZ IDwNDhHDuJqnjztnQG796yQDaMei0D1s4s2u0lVThJrx5yAkZP5FORX40M5h5mgn 8HtU6rKzNfK3c9o83V5bQUCZ+882gA== =oihI -----END PGP SIGNATURE----- --=-=-=--