unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38069@debbugs.gnu.org, Jan Nieuwenhuizen <janneke@gnu.org>
Subject: [bug#38069] [PATCH]: Adjust make-bootstrap linux headers
Date: Fri, 15 Nov 2019 17:35:48 +0100	[thread overview]
Message-ID: <87r229yu57.fsf@gnu.org> (raw)
In-Reply-To: <20191105125633.GA14453@E5400> (Efraim Flashner's message of "Tue, 5 Nov 2019 14:56:33 +0200")

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 1a4f163ca174d5edc09db0dacd2ff188ee4cc1ae Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 5 Nov 2019 14:55:05 +0200
> Subject: [PATCH] make-bootstrap: Adjust copied linux headers.
>
> * guix/build/make-bootstrap.scm (copy-linux-headers): Remove header
> file 'a.out.h' is no longer part of the linux kernel headers.
> ---
>  guix/build/make-bootstrap.scm | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/guix/build/make-bootstrap.scm b/guix/build/make-bootstrap.scm
> index e5ef1d6d2b..0d29338ce3 100644
> --- a/guix/build/make-bootstrap.scm
> +++ b/guix/build/make-bootstrap.scm
> @@ -47,7 +47,6 @@ bootstrap libc."
>                  (install-file (pk 'src (string-append kernel-headers "/include/linux/" file))
>                                (pk 'dest (string-append incdir "/linux"))))
>                '(
> -                "a.out.h"               ; for 2.2.5

Looking at the comment here, which was added by Janneke, I suspect this
header is actually required to build glibc 2.2.5 in commencement.scm.
Did I get it right, Janneke?

If so, perhaps we should reinstate it and simply add a

  when (file-exists? file)

guard before calling ‘install-file’?

Thanks,
Ludo’.

      parent reply	other threads:[~2019-11-15 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 12:56 [bug#38069] [PATCH]: Adjust make-bootstrap linux headers Efraim Flashner
2019-11-13 22:14 ` Ludovic Courtès
2019-11-14  8:30   ` Efraim Flashner
2019-11-14 21:23     ` Ludovic Courtès
2019-11-15 11:01       ` bug#38069: " Efraim Flashner
2019-11-16 15:51         ` [bug#38069] " Ludovic Courtès
2019-11-15 16:35 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r229yu57.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38069@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).