unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@posteo.net>
To: "h.nasajpour" <h.nasajpour@pantherx.org>
Cc: 35975@debbugs.gnu.org
Subject: [bug#35975] [PATCH 43/47] gnu: Add python-mypy.
Date: Tue, 10 Dec 2019 00:42:30 -0600	[thread overview]
Message-ID: <87r21ck7ft.fsf@posteo.net> (raw)
In-Reply-To: <20190529003550.3213-1-h.nasajpour@pantherx.org> (h. nasajpour's message of "Wed, 29 May 2019 05:05:50 +0430")

"h.nasajpour" <h.nasajpour@pantherx.org> writes:

> * gnu/packages/python-xyz.scm (python-mypy): New variable
> * gnu/packages/python-xyz.scm (python-mypy_extensions): New variable
> ---
>  gnu/packages/python-xyz.scm | 41 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 93783d17ee..298a59f59f 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -15495,4 +15495,45 @@ by Igor Pavlov.")
>  	 as they are based on the CPython 2.7 and 3.6 parsers.")
>      (license license:expat)))
>  
> +(define-public python-mypy_extensions
> +  (package
> +  (name "python-mypy_extensions")
> +    (version "0.4.1")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "mypy_extensions" version))
> +      (sha256 (base32 "04h8brrbbx151dfa2cvvlnxgmb5wa00mhd2z7nd20s8kyibfkq1p"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f))
> +    (home-page "http://www.mypy-lang.org/")
> +    (synopsis "Experimental type system extensions for programs checked with the mypy typechecker.")
> +    (description
> +     "The “mypy_extensions” module defines experimental extensions to the standard “typing” module that are supported by the mypy typechecker..")
> +    (license license:expat)))
> +
> +(define-public python-mypy
> +  (package
> +  (name "python-mypy")
> +    (version "0.701")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "mypy" version))
> +      (sha256 (base32 "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f))
> +	(inputs `(
> +		("python-typed-ast" , python-typed-ast)
> +		("python-mypy_extensions" , python-mypy_extensions)
> +		("python-typed-ast" , python-typed-ast)
> +		))
> +    (home-page "http://www.mypy-lang.org/")
> +    (synopsis "Optional static typing for Python (mypyc-compiled version)")
> +    (description
> +     "Add type annotations to your Python programs, and use mypy to type check them.
> +	 Mypy is essentially a Python linter on steroids, and it can catch many programming errors by analyzing your program,
> +	 without actually having to run it. Mypy has a powerful type system with features such as type inference,
> +	 gradual typing, generics and union types.")
> +    (license license:expat)))

Hi,

This package requires a few revisions before it can be merged to master.

If you could separate the packages out either as separate patches in a
series or by having the extensions package as a native input defined
inline of the `python-mypy' package that would be terrific!

Additionally, there are several issues with indentation. Generally we do
not like open and close parenthesis along on lines by
themselves. Additionally there are some issues with your
description. Make sure to run `guix lint` to catch some of these issues.

Lastly, this package has a new version upstream.

If you need help let me know! Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

  reply	other threads:[~2019-12-10  6:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  0:35 [bug#35975] [PATCH 43/47] gnu: Add python-mypy h.nasajpour
2019-12-10  6:42 ` Brett Gilio [this message]
2022-04-07 13:04 ` bug#35975: " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r21ck7ft.fsf@posteo.net \
    --to=brettg@posteo.net \
    --cc=35975@debbugs.gnu.org \
    --cc=h.nasajpour@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).