From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivf5H-0000BE-He for guix-patches@gnu.org; Sun, 26 Jan 2020 05:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivf5G-00046Q-Gv for guix-patches@gnu.org; Sun, 26 Jan 2020 05:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50565) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivf5G-000466-Dg for guix-patches@gnu.org; Sun, 26 Jan 2020 05:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivf5G-0007hU-4c for guix-patches@gnu.org; Sun, 26 Jan 2020 05:24:02 -0500 Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-Message-ID: References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> From: Christopher Baines In-reply-to: <20200125123027.50a6ab1a@scratchpost.org> Date: Sun, 26 Jan 2020 10:23:09 +0000 Message-ID: <87r1zmikj6.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 39275@debbugs.gnu.org, jgibbons2357@gmail.com --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi, > > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > >> It would be good to put something in the commit message about why this >> is happening, as it's not obvious to me at least. > > I disagree in general because I've seen before what that leads to: > Half the source code (the comments) end up in the commit messages instead. > Eventually (because of some merge or something) those get lost, or > (because of a new commit) those get hidden. > Now someone is going to overlook it. I'm not suggesting documenting code in commit messages, just saying something about the motivation/intention with the change is useful. The message you suggest meets this criteria perfectly. > So I'd put documentation into comments, except when it's ephemeral ("news"). > > Also, in the special case of Guix the reason why we add an input later is > "we forgot to add it earlier and it was optional to the package and thus the > package built" most of the time. So the commit message would always be > "we forgot earlier". So I would say that "we forgot earlier" isn't a motivation, or descriptive of intent (although maybe it meets the "why this is happening" I mentioned earlier, but that was maybe poorly explained).. > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody > noticed. > > We could have the subject say "Add MIDI support" because it communicates more > clearly what this commit does for users. And that's the news :) Yeah, I think that's good. At least in the context I was looking at this, trying to review the change, knowing what the intent is allows me to check if that's been satisfied (trying to play some MIDI content with VLC before and after). Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4taI1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdIXA/8DFwiy59RysatwCaD7WUTjwtjcmL50rvaGt4mD+hoxK7RuxJY/9zWEJ8M ArkgrBby4JeTiV9m5gsu3WSSF/f6mVr6W3lSPsQGLIFL8/5Xs3ZLvIrulM6Lua0c Q6WnLZtQqaf4Um+5NsVxEUkP+ZgNLawLfwGsCBd52TpBEJXEakx3bw8f2uVt7yFR lgkdljrRP+DjhbS55ZkJYCqFwH5rA4ohHz8NccjTihdI4vuVhJqSogt/4yLvJgHG tVzmc1QUG1fecdTgwj04oZ9ntPR83516Ow79Y+9vJ6P+chb0obGgV3eDXUFegQ3o OvlgpfkvER/seY5CWqrC67MilTG+kD2ANDr1YYLiUithd3szm0ooelD+0jkk12tq WrZ/Jbp1RhfMuE14jskGst/V17+jzOUeTfjFXATJ76LsOVWY3xzU0EAr74VQsitD 75YQDIFTtENmDHic+wrqqiW/dELC6UGamct38kCJZEzLutU3VbxuOP1VjUuY3pxy K3Xgesz8HYYURx7tSEvVau+wxT1JOfqalkgkk+v9ND/qviNw59poS6eO99G67b0M OnxBQV7itLrAPSqhgynIjRvF2pC/05kfe8lNxEr96kB/ddAt55g5GcBVQknpltxz hFw2T6aY0soDCxlDyYxBVlkP7JdPJSqUQzh79rl9cvgksCIGwg8= =QQ0Q -----END PGP SIGNATURE----- --=-=-=--