From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix992-0000kU-Ez for guix-patches@gnu.org; Thu, 30 Jan 2020 07:42:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix990-0000Hl-IL for guix-patches@gnu.org; Thu, 30 Jan 2020 07:42:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix990-0000Gl-C0 for guix-patches@gnu.org; Thu, 30 Jan 2020 07:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ix990-00039h-8h for guix-patches@gnu.org; Thu, 30 Jan 2020 07:42:02 -0500 Subject: [bug#37654] [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. Resent-Message-ID: From: Marius Bakke In-Reply-To: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> References: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> Date: Thu, 30 Jan 2020 13:41:50 +0100 Message-ID: <87r1zhnmk1.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brendan Tildesley , 37654@debbugs.gnu.org --=-=-= Content-Type: text/plain Hello Brendan, sorry for the sloooow response. Brendan Tildesley writes: > I just made this after discovering a source repo with a bootstrap > directory. Naturally it results in just about everything being rebuilt, > so it would a long time to fully test it, and I'm no experienced schemer > so I can't be sure this is the right way to add in this change. Feel > free to rewrite it a better way. Were you able to verify that it DTRT? > From 3a602cccbd8711f40f6b981e5616289a5fdd0b56 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Tue, 8 Oct 2019 02:55:03 +1100 > Subject: [PATCH] gnu-build-system: Don't try executing directories in > bootstrap phase. > > * guix/build/gnu-build-system.scm: (bootstrap): Change the file-exists? > procedure to one that excludes directories, so that we do not mistake it for a > script. For example if the source includes a bootstrap/ directory. The patch LGTM. Will push it in a few days unless anyone protests! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4yzw4ACgkQoqBt8qM6 VPrxYAf8Ci5dwhyGjJmPv818dHK1fQU2szna306sGLvt2/PjRsyw7BxiiXImanzT Oy0TJG+m8gQY6N1yTMtdsA7DCFLsRx9b+8Cnd5KupGBHkJYZWSFLxbzeHcnSitFy HnAelWtPJ7eJJ46zB1MLUim9dRZOECtGWiYE/MPpIcw5vx2YkXEAlVb1UJcLDxxH jDhv1Z2B0fijw0eI/mehiFiXWc8pj4k+NgjyvNILo4SeD7N0lOs8G4aQONrTEm94 vgFu8KsKEiB3qAgL/ORIi61V/YgnWgrYa37hsBVkatg5CxmdHrhy3XhN3TyYmA7h A2/2koI2q/Z6KM7Bheb6gFJQkOtLcw== =JAYq -----END PGP SIGNATURE----- --=-=-=--