From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KMS3H/09vl6PDQAA0tVLHw (envelope-from ) for ; Fri, 15 May 2020 07:00:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gPK3G/09vl47WAAAB5/wlQ (envelope-from ) for ; Fri, 15 May 2020 07:00:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02E1E940145 for ; Fri, 15 May 2020 07:00:12 +0000 (UTC) Received: from localhost ([::1]:55236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZUKI-0007aR-Ie for larch@yhetil.org; Fri, 15 May 2020 03:00:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZUKA-0007aE-Pn for guix-patches@gnu.org; Fri, 15 May 2020 03:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZUKA-0002to-GZ for guix-patches@gnu.org; Fri, 15 May 2020 03:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZUKA-00079a-CL for guix-patches@gnu.org; Fri, 15 May 2020 03:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40677] [PATCH v4] gnu: Add ffmpeg-jami. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 May 2020 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40677 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jan Cc: 40677@debbugs.gnu.org Received: via spool by 40677-submit@debbugs.gnu.org id=B40677.158952599127445 (code B ref 40677); Fri, 15 May 2020 07:00:02 +0000 Received: (at 40677) by debbugs.gnu.org; 15 May 2020 06:59:51 +0000 Received: from localhost ([127.0.0.1]:35729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZUJy-00078b-NQ for submit@debbugs.gnu.org; Fri, 15 May 2020 02:59:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZUJw-00078L-OK for 40677@debbugs.gnu.org; Fri, 15 May 2020 02:59:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52278) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZUJq-0002rY-OD; Fri, 15 May 2020 02:59:42 -0400 Received: from [2a01:cb18:832e:5f00:5cdd:cc67:a2e1:e2f0] (port=57890 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jZUJq-00070c-Ad; Fri, 15 May 2020 02:59:42 -0400 From: Mathieu Othacehe References: <20200417015857.0650ff6a@interia.pl> <20200513181234.27548-1-tona_kosmicznego_smiecia@interia.pl> <87zhab2e00.fsf@gnu.org> <20200514144324.346f0bc5@kompiuter> Date: Fri, 15 May 2020 08:59:40 +0200 In-Reply-To: <20200514144324.346f0bc5@kompiuter> (Jan's message of "Thu, 14 May 2020 14:43:24 +0200") Message-ID: <87r1vlwun7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: K6/FfM5FaNfU Hey, > What should I use instead? Here you can create the list statically using quasi-quotes. >> If the first branch of the cond succeeds, we will never add this flag. > That's what happens when you code late in night :) > I should sit down with a cup of coffee and read Guile's manual seriously > this time. Sorry for making your code review harder. No worries. > > I think %ffmpeg-linux-x86-configure-flags should be added only if > linux is present, not just when on i686 or x86_64. I called it > "%ffmpeg-linux-x86...", because it was inside of the "ifdef HAVE_LINUX" > condition. But there was also a comment saying "Desktop Linux", which > as always means very little. I'm not sure if it really requires the > Linux kernel there or what. Yes you are right. > What about the output of the procedure? Is it okay for the list to be > not proper? It will look something like this: > ((flag1 flag2 ... flagN) (flag1 flag2 ... flagN)) > Is it okay because everything is treated as a pair in a recursive > manner? Nope the list should be flat, see: https://www.gnu.org/software/guile/manual/html_node/Expression-Syntax.html. Thanks, Mathieu