From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41756-done@debbugs.gnu.org
Subject: bug#41756: [PATCH] gnome: gnome-desktop: Add bubblewrap as an input.
Date: Sat, 13 Jun 2020 12:04:38 +0100 [thread overview]
Message-ID: <87r1uj8bw9.fsf@cbaines.net> (raw)
In-Reply-To: <87r1uoofl0.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> (There’s a typo in the subject prefix.)
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> This is expected to be available, oddly as libseccomp is available. These
>> changes fix thumbnails for Nautilus.
>>
>> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap
>> phase.
>> [inputs]: Add bubblewrap.
>
> Nice, I didn’t know the thumbnailer would do that.
>
>> + (add-before 'configure 'patch-bubblewrap
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c"
>> + (("\"bwrap\",")
>> + (string-append "\"" (which "bwrap") "\","))
>> + (("\"--ro-bind\", \"/usr\", \"/usr\",")
>> + (string-append "\"--ro-bind\", \""
>> + (%store-directory)
>> + "\", \""
>> + (%store-directory)
>> + "\","))
>> + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cache\",")
>> + "\"--ro-bind\", \"/run/current-system\", \"/run/current-system\","))
>
> Perhaps we can replace this second --ro-bind with the empty string?
>
> Otherwise LGTM!
Great, I've replaced the second --ro-bind as you suggested, that seems
not to be necessary. I've pushed as
3857aba7ab25c50d64a6d7468d2b5b09bc4f5d60.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
prev parent reply other threads:[~2020-06-13 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 20:22 [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input Christopher Baines
2020-06-09 7:36 ` Ludovic Courtès
2020-06-13 11:04 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1uj8bw9.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=41756-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).