From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 3DSMFqFu9F4GEwAA0tVLHw (envelope-from ) for ; Thu, 25 Jun 2020 09:30:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cAjVEaFu9F5cKwAAbx9fmQ (envelope-from ) for ; Thu, 25 Jun 2020 09:30:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD48A940221 for ; Thu, 25 Jun 2020 09:30:08 +0000 (UTC) Received: from localhost ([::1]:52896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joOCs-0006c3-Gw for larch@yhetil.org; Thu, 25 Jun 2020 05:30:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joOCo-0006bg-J1 for guix-patches@gnu.org; Thu, 25 Jun 2020 05:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joOCo-0003q3-9Q for guix-patches@gnu.org; Thu, 25 Jun 2020 05:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joOCo-0000nd-35 for guix-patches@gnu.org; Thu, 25 Jun 2020 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Jun 2020 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42030 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 42030@debbugs.gnu.org Received: via spool by 42030-submit@debbugs.gnu.org id=B42030.15930773613000 (code B ref 42030); Thu, 25 Jun 2020 09:30:02 +0000 Received: (at 42030) by debbugs.gnu.org; 25 Jun 2020 09:29:21 +0000 Received: from localhost ([127.0.0.1]:39702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joOC9-0000mJ-JO for submit@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joOC6-0000m6-87 for 42030@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36937) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joOC1-0003eA-0Y for 42030@debbugs.gnu.org; Thu, 25 Jun 2020 05:29:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33492 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joOBz-0006w3-92; Thu, 25 Jun 2020 05:29:12 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 25 Jun 2020 11:29:07 +0200 In-Reply-To: <87d05o6ubc.fsf@gnu.org> (Marius Bakke's message of "Wed, 24 Jun 2020 23:13:43 +0200") Message-ID: <87r1u3trx8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: c83oBCkRIYjR Hi, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> * guix/channels.scm (latest-channel-instance): Raise an error instead of >> warning when 'guix is unauthenticated. >> * tests/channels.scm ("latest-channel-instances, missing introduction fo= r 'guix'"): >> New test. > > The hunk in tests/channels.scm does not apply. :-) LGTM, anyway. Ah, maybe because you were too fast: it depends on a18d02def9862dfb9b7a5e3d5aa3b541b066d198, which I pushed yesterday. > I think we should export %guix-channel-introduction, or alternatively > add a %default-guix-channel that can be inherited, for easy access in > custom channels.scm files. WDYT? The idea was to expose only =E2=80=98%default-channels=E2=80=99, which leav= es room for the possibility of having multiple channels by default. I=E2=80=99d rather avoid exposing the individual bits as that=E2=80=99s a bit of an additional committment. But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix chann= el is automatically added anyway (commit c3f6f564e909ebefe752d24b325871a4e3a02d40). Thanks for your feedback! Ludo=E2=80=99.