From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uFZfNyh//F7DfwAA0tVLHw (envelope-from ) for ; Wed, 01 Jul 2020 12:18:48 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MLc6Myh//F4DYAAAB5/wlQ (envelope-from ) for ; Wed, 01 Jul 2020 12:18:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by aspmx2.migadu.com (Postfix) with ESMTP id 8E50F68053D for ; Wed, 1 Jul 2020 12:18:46 +0000 (UTC) Received: from localhost ([::1]:38632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqbbz-0006HH-5p for larch@yhetil.org; Wed, 01 Jul 2020 08:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqbbr-0006H8-Bk for guix-patches@gnu.org; Wed, 01 Jul 2020 08:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqbbp-000635-S0 for guix-patches@gnu.org; Wed, 01 Jul 2020 08:13:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqbbp-00083y-MO for guix-patches@gnu.org; Wed, 01 Jul 2020 08:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42048] [PATCH 6/6] services: provenance: Save channel introductions. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Jul 2020 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42048 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Ricardo Wurmus , 42048@debbugs.gnu.org Received: via spool by 42048-submit@debbugs.gnu.org id=B42048.159360554530946 (code B ref 42048); Wed, 01 Jul 2020 12:13:01 +0000 Received: (at 42048) by debbugs.gnu.org; 1 Jul 2020 12:12:25 +0000 Received: from localhost ([127.0.0.1]:52464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqbbF-000834-7q for submit@debbugs.gnu.org; Wed, 01 Jul 2020 08:12:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqbbD-00082q-BI for 42048@debbugs.gnu.org; Wed, 01 Jul 2020 08:12:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38104) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqbb7-0005zz-1y; Wed, 01 Jul 2020 08:12:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=53970 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jqbb6-0004UQ-1x; Wed, 01 Jul 2020 08:12:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200625211605.29316-1-ludo@gnu.org> <20200625211605.29316-6-ludo@gnu.org> <87v9j8mtx9.fsf@elephly.net> <87imf847sr.fsf@gnu.org> <86lfk3aa9p.fsf@gmail.com> Date: Wed, 01 Jul 2020 14:12:11 +0200 In-Reply-To: <86lfk3aa9p.fsf@gmail.com> (zimoun's message of "Wed, 01 Jul 2020 10:51:14 +0200") Message-ID: <87r1tvzb6s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: LSw+W3smrMLr Hi Simon, zimoun skribis: > On Tue, 30 Jun 2020 at 22:28, Ludovic Court=C3=A8s wrote: > >>> One thing that I worry about is authentication of channels that are >>> added as dependencies of user-selected channels. Let=E2=80=99s say my = channel >>> =E2=80=9Cguix-bimsb=E2=80=9D depends on =E2=80=9Cguix-past=E2=80=9D. H= ow will users of =E2=80=9Cguix-bimsb=E2=80=9D >>> authenticate the commits of =E2=80=9Cguix-past=E2=80=9D when they don= =E2=80=99t know about >>> =E2=80=9Cguix-past=E2=80=9D (they only care about =E2=80=9Cguix-bimsb= =E2=80=9D), and don=E2=80=99t explicitly >>> add introduction information to their channels file? >>> >>> Is there something that the authors of =E2=80=9Cguix-bimsb=E2=80=9D can= do to not only >>> indicate the dependency on =E2=80=9Cguix-past=E2=80=9D, but also to att= ach introduction >>> information? Will the format of the =E2=80=9C.guix-channel=E2=80=9D ne= ed to be >>> adjusted? >> >> That=E2=80=99s a very good question and I had completely overlooked it. > > H=C3=A9h=C3=A9, yet I had the same question one month ago. :-) Oh I=E2=80=99m sorry, I think I misunderstood your question back then! >> With this patch set, someone pulling guix-bimsb would just end up >> pulling guix-past unauthenticated; there=E2=80=99s not even a warning. >> >> (There=E2=80=99s currently a warning in (guix channels), but only when p= ulling >> an unauthenticated 'guix channel. It=E2=80=99s perhaps too early to hav= e that >> warning enabled for all channels. WDYT?) > > Enable the warning appears to me a good idea because this dependency is > like "doing something I am not necessary aware in my back". I=E2=80=99m talking about the warning that says =E2=80=9Cthis channel is unauthenticated=E2=80=9D, which is mostly orthogonal to the discussion at h= and. The reason I said it=E2=80=99s perhaps too early to enable it is that people haven=E2=80=99t had a chance to make their channel =E2=80=9Cauthenticable= =E2=80=9D yet. >> So yes, I suppose we would need to extend the =E2=80=98.guix-channel=E2= =80=99 format for >> dependencies. Luckily it should be quite simply because that format is >> extensible; older Guix versions would ignore the =E2=80=98introduction= =E2=80=99 field. >> It would look something like this: >> >> (channel >> (version 0) >> (dependencies >> (channel >> (name some-collection) >> (url "https://example.org/first-collection.git") >> (introduction (channel-introduction >> (version 0) >> (commit "=E2=80=A6") >> (signer "=E2=80=A6")))) >> (channel >> (name some-other-collection) >> (url "https://example.org/second-collection.git") >> (branch "testing")))) ;not an authenticated channel >> >> It does mean that a channel can indirectly trick you into turning off >> authentication for a dependent channel. But I think that=E2=80=99s with= in the >> expectations for channels: when you choose a channel, you trust it >> enough to run its code. > > Sound good to me. Alright, I=E2=80=99ll do that as a followup. Thanks! Ludo=E2=80=99.