From: Christopher Baines <mail@cbaines.net>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 42229@debbugs.gnu.org
Subject: [bug#42229] [[PATCH V2] 03/10] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source.
Date: Sat, 11 Jul 2020 20:52:56 +0100 [thread overview]
Message-ID: <87r1thkew7.fsf@cbaines.net> (raw)
In-Reply-To: <20200710183220.19829-3-tona_kosmicznego_smiecia@interia.pl>
[-- Attachment #1: Type: text/plain, Size: 3424 bytes --]
Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes:
> * gnu/packages/jami.scm:
> (libring-source): [without-contrib] is now true by default.
> (jami-apply-dependency-patches): Do not invoke tar,
> patches are now fetched from git.
> Apply "--ignore-whitespace" to patch to prevent failing.
> (pjproject-jami)[native-inputs]: Use (libring-source) procedure instead of
> (jami-source).
> [arguments]: Add new patches.
> (ffmpeg-jami)[native-inputs]: Use (libring-source) procedure instead of
> (jami-source).
> ---
> gnu/packages/jami.scm | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/jami.scm b/gnu/packages/jami.scm
> index abb0edc933..1da50d7744 100644
> --- a/gnu/packages/jami.scm
> +++ b/gnu/packages/jami.scm
> @@ -67,7 +67,7 @@
> (define %libring-commit "07188b4a717e5ac6e582d71c895b74fbbfd02b24")
> (define %libring-revision "0")
>
> -(define* (libring-source #:key without-contrib)
> +(define* (libring-source #:key (without-contrib #t))
> (origin
> (method git-fetch)
> (uri (git-reference
> @@ -92,16 +92,13 @@
> ;; package easy.
> (define jami-apply-dependency-patches
> '(lambda* (#:key inputs dep-name patches)
> - (let ((patches-directory "sfl-patches"))
> - (mkdir-p patches-directory)
> - (invoke "tar" "-xvf" (assoc-ref inputs "sfl-patches")
> - "-C" patches-directory
> - "--strip-components=5"
> - (string-append "ring-project/daemon/contrib/src/"
> - dep-name))
> + (let ((patches-directory (string-append
> + (assoc-ref inputs "sfl-patches")
> + "/contrib/src/" dep-name)))
> (for-each
> (lambda (file)
> - (invoke "patch" "--force" "-p1" "-i"
> + (invoke "patch" "--force"
> + "--ignore-whitespace" "-p1" "-i"
> (string-append patches-directory "/"
> file ".patch")))
> patches))))
> @@ -111,7 +108,7 @@
> (inherit pjproject)
> (name "pjproject-jami")
> (native-inputs
> - `(("sfl-patches" ,(jami-source))
> + `(("sfl-patches" ,(libring-source #:without-contrib #f))
> ,@(package-native-inputs pjproject)))
> (arguments
> `(#:tests? #f
> @@ -174,7 +171,9 @@
> "0006-ignore_ipv6_on_transport_check"
> "0007-pj_ice_sess"
> "0008-fix_ioqueue_ipv6_sendto"
> - "0009-add-config-site"))
> + "0009-add-config-site"
> + "0010-fix-pkgconfig"
> + "0011-fix-tcp-death-detection"))
> #t)))
> ;; TODO: We could use substitute-keyword-arguments instead of
> ;; repeating the phases from pjproject, but somehow it does
> @@ -414,7 +413,7 @@
> (inherit ffmpeg)
> (name "ffmpeg-jami")
> (native-inputs
> - `(("sfl-patches" ,(jami-source))
> + `(("sfl-patches" ,(libring-source #:without-contrib #f))
> ("libiconv" ,libiconv)
> ,@(package-native-inputs ffmpeg)))
> (supported-systems '("x86_64-linux" "i686-linux"
Relating to my comment on the first patch on this series, these changes
here look like part of that change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-07-11 19:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 15:34 [bug#42229] [PATCH 0/9] Jami update and refactor Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 1/9] gnu: libring: Fetch from git, update to 20200702-guix Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 2/9] gnu: libringclient: " Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 3/9] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 4/9] gnu: jami: Fetch from git, update to 20200702-guix Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 5/9] gnu: pjproject-jami: Make sure phases are run in order Jan Wielkiewicz
2020-08-04 4:20 ` maxim.cournoyer
2020-08-04 13:05 ` Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 6/9] gnu: jami: Add libnm as input Jan Wielkiewicz
2020-07-06 21:24 ` Christopher Baines
2020-07-10 18:03 ` Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 7/9] gnu: libringclient: Do not propagate qtbase in libringclient Jan Wielkiewicz
2020-07-06 20:56 ` Christopher Baines
2020-07-07 23:13 ` Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessary webchat files Jan Wielkiewicz
2020-07-06 21:19 ` Christopher Baines
2020-07-07 21:22 ` Jan Wielkiewicz
2020-07-08 19:14 ` Christopher Baines
2020-07-07 23:07 ` Jan Wielkiewicz
2020-08-04 4:40 ` maxim.cournoyer
2020-08-04 13:02 ` Jan Wielkiewicz
2020-07-06 15:50 ` [bug#42229] [PATCH 9/9] gnu: pjproject-jami: Fix assertion by disabling debugging Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 01/10] gnu: libring: Fetch from git, update to 20200708-guix Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 02/10] gnu: libringclient: Fetch from git, update to 20200702-guix Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 03/10] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source Jan Wielkiewicz
2020-07-11 19:52 ` Christopher Baines [this message]
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 04/10] gnu: jami: Fetch from git, update to 20200702-guix Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 05/10] gnu: pjproject-jami: Make sure phases are run in order Jan Wielkiewicz
2020-07-11 19:57 ` Christopher Baines
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 06/10] gnu: jami: Add libnm as input Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 07/10] gnu: jami: Fix compilation by providing necessary webchat files Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 08/10] gnu: pjproject-jami: Fix assertion by disabling debugging Jan Wielkiewicz
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 09/10] gnu: opendht: Fix libring compilation Jan Wielkiewicz
2020-07-11 20:12 ` Christopher Baines
2020-07-10 18:32 ` [bug#42229] [[PATCH V2] 10/10] gnu: jami-client-gnome: Remove deprecated package Jan Wielkiewicz
2020-07-11 19:51 ` [bug#42229] [[PATCH V2] 01/10] gnu: libring: Fetch from git, update to 20200708-guix Christopher Baines
2020-07-12 16:00 ` [bug#42229] [[PATCH v3] 1/4] gnu: jami-client-gnome: Remove deprecated package Jan Wielkiewicz
2020-07-12 16:00 ` [bug#42229] [[PATCH v3] 2/4] gnu: opendht: Fix compilation of software using this package Jan Wielkiewicz
2020-07-12 16:00 ` [bug#42229] [[PATCH v3] 3/4] gnu: jami: Bump to 20200710.1.6bd18d2 Jan Wielkiewicz
2020-07-12 16:00 ` [bug#42229] [[PATCH v3] 4/4] gnu: pjproject-jami: Fix assertion bug Jan Wielkiewicz
2020-07-12 19:36 ` [bug#42229] [[PATCH v3] 1/4] gnu: jami-client-gnome: Remove deprecated package Christopher Baines
2021-03-31 5:27 ` bug#42229: [PATCH 0/9] Jami update and refactor Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1thkew7.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=42229@debbugs.gnu.org \
--cc=tona_kosmicznego_smiecia@interia.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).