unofficial mirror of guix-patches@gnu.org 
 help / color / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: Pierre Langlois <pierre.langlois@gmx.com>, 42608@debbugs.gnu.org
Subject: [bug#42608] [PATCH] gnu: emacs-org-roam: Update to 1.2.1.
Date: Sun, 02 Aug 2020 14:43:15 +0100
Message-ID: <87r1spnoy4.fsf@gmx.com> (raw)
In-Reply-To: <873655tcio.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi Oleg, thanks for taking a look!

Oleg Pykhalov writes:

> Hi,
>
> Could you take a look on running the test-suite inside
> emacsql-sqlite3-test.el file, please?

Oh yes good idea! I hadn't noticed there were tests.


See attached patch, I copied the test invocation from
https://github.com/cireu/emacsql-sqlite3/blob/master/.github/workflows/main.yml#L40.
I've also removed the ".git" from the origin url, to make 'guix lint'
happy.

Thanks!
Pierre


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-emacsql-sqlite3.patch --]
[-- Type: text/x-patch, Size: 2521 bytes --]

From e35c09f4741fe4a8e61b3c1e7da45434ede63a09 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Thu, 30 Jul 2020 00:20:43 +0100
Subject: [PATCH] gnu: Add emacs-emacsql-sqlite3.

* gnu/packages/emacs-xyz.scm (emacs-emacsql-sqlite3): New variable.
---
 gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a90d789d7a..fa9e259485 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -13572,6 +13572,45 @@ has no concept of @code{TEXT} values; it's all just Lisp objects.  The Lisp
 object @code{nil} corresponds 1:1 with @code{NULL} in the database.")
     (license license:gpl3+)))

+(define-public emacs-emacsql-sqlite3
+  (package
+    (name "emacs-emacsql-sqlite3")
+    (version "1.0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/cireu/emacsql-sqlite3")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1yy9y27rckm776jnl2rh1fz3bh09690xwzq7102vlw7xkb9s7jhj"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("ert-runner" ,emacs-ert-runner)))
+    (inputs
+     `(("sqlite" ,sqlite)))
+    (propagated-inputs
+     `(("emacs-emacsql" ,emacs-emacsql)))
+    (arguments
+     `(#:tests? #t
+       #:test-command '("emacs" "-Q" "--batch" "-L" "."
+                         "--load" "emacsql-sqlite3-test.el"
+                         "-f" "ert-run-tests-batch-and-exit")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'embed-path-to-sqlite3
+           (lambda _
+             (substitute* "emacsql-sqlite3.el"
+               (("\\(executable-find \"sqlite3\"\\)")
+                 (string-append "\"" (which "sqlite3") "\"")))
+             #t)))))
+    (home-page "https://github.com/cireu/emacsql-sqlite3")
+    (synopsis "EmacSQL backend for SQLite")
+    (description "This is yet another EmacSQL backend for SQLite which uses
+official @command{sqlite3} executable to access SQL database.")
+    (license license:gpl3+)))
+
 (define-public emacs-closql
   ;; Take a commit newer than 1.0.0 release because of Emacs upgrade to 26.3.
   (let ((commit "70b98dbae53611d10a461d9b4a6f71086910dcef"))
--
2.28.0


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 23:50 Pierre Langlois
2020-08-02 13:15 ` Oleg Pykhalov
2020-08-02 13:43   ` Pierre Langlois [this message]
2020-08-02 13:50     ` [bug#42608] fixup! Pierre Langlois
2020-08-02 15:04       ` bug#42608: fixup! Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1spnoy4.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=42608@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

Archives are clonable:
	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git