From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WMA5JjsSLV+jAQAA0tVLHw (envelope-from ) for ; Fri, 07 Aug 2020 08:35:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SH8CIjsSLV/iUAAAbx9fmQ (envelope-from ) for ; Fri, 07 Aug 2020 08:35:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FC3C9402D1 for ; Fri, 7 Aug 2020 08:35:07 +0000 (UTC) Received: from localhost ([::1]:34822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3xqE-0005ah-2F for larch@yhetil.org; Fri, 07 Aug 2020 04:35:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3xqA-0005Zz-5Z for guix-patches@gnu.org; Fri, 07 Aug 2020 04:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3xq9-0004SI-RN for guix-patches@gnu.org; Fri, 07 Aug 2020 04:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3xq9-0001uy-P5 for guix-patches@gnu.org; Fri, 07 Aug 2020 04:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42725] [PATCH] drawpile package (sans upnp) Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raingloom Cc: 42725@debbugs.gnu.org Received: via spool by 42725-submit@debbugs.gnu.org id=B42725.15967892757330 (code B ref 42725); Fri, 07 Aug 2020 08:35:01 +0000 Received: (at 42725) by debbugs.gnu.org; 7 Aug 2020 08:34:35 +0000 Received: from localhost ([127.0.0.1]:55657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3xpj-0001uA-7R for submit@debbugs.gnu.org; Fri, 07 Aug 2020 04:34:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3xph-0001tw-2S for 42725@debbugs.gnu.org; Fri, 07 Aug 2020 04:34:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38503) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3xpb-0004OP-FK; Fri, 07 Aug 2020 04:34:27 -0400 Received: from pop.92-184-100-121.mobile.abo.orange.fr ([92.184.100.121]:42930 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k3xpZ-0006KW-VR; Fri, 07 Aug 2020 04:34:26 -0400 From: Mathieu Othacehe References: <20200806002933.1e1996bb@riseup.net> Date: Fri, 07 Aug 2020 10:34:22 +0200 In-Reply-To: <20200806002933.1e1996bb@riseup.net> (raingloom@riseup.net's message of "Thu, 6 Aug 2020 00:29:33 +0200") Message-ID: <87r1sionw1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 0.3 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: rlx1j3G/H7Rk Hello, > + (method url-fetch) > + (uri (string-append "https://github.com/drawpile/Drawpile/archive/" > + version > + ".tar.gz")) We prefer not to use those github archives that can be re-generated and prefer to use "git-fetch" method instead. > + (sha256 > + (base32 > + "0brscm95nay31xa1c02n1w144gg9hm8pxwa9sfnis0x5dj2nkrb7")))) > + (build-system qt-build-system) > + (arguments '(#:tests? #f)) You should explain why tests are not run with a comment. > + (native-inputs > + `(("extra-cmake-modules" ,extra-cmake-modules))) > + (inputs > + `(("giflib" ,giflib) > + ("karchive" ,karchive) > + ("kdnssd" ,kdnssd) > + ("libmicrohttpd" ,libmicrohttpd) > + ("libsodium" ,libsodium) > + ("libvpx" ,libvpx) > + ;("miniupnpc" ,miniupnpc) ;; TODO segfaults for some reason No need to comment twice. > + ("qtbase" ,qtbase) > + ("qtkeychain" ,qtkeychain) > + ("qtmultimedia" ,qtmultimedia) > + ("qtsvg" ,qtsvg))) > + (home-page "https://drawpile.net") > + (synopsis "Collaborative drawing program") > + (description > +"Drawpile is a drawing program that lets you share the canvas with other users > +in real time. > + > +Some feature highlights: > +Runs on Linux, Windows and OSX No need to talk about those operating systems I think. > +Shared canvas using the built-in server or a dedicated server > +Record, play back and export drawing sessions > +Simple animation support > +Layers and blending modes > +Text layers > +Supports pressure sensitive Wacom tablets > +Built-in chat > +Supports OpenRaster file format > +Encrypted connections using SSL > +Automatic port forwarding with UPnP") You could use texinfo to render this list nicely. See "libmemcached" package for an example. Could you send an updated patch? Thanks, Mathieu